Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1178)

Unified Diff: chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc

Issue 2354333002: Remove calls to MessageLoop(ForUI|ForIO)::Run/RunUntilIdle. (Closed)
Patch Set: fix build error Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc
diff --git a/chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc b/chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc
index e5ff19442a5cc782e65111196e834ea117693ce8..731ddadf0ebd9f36f6c84fadf61521f10452359a 100644
--- a/chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc
+++ b/chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc
@@ -10,7 +10,9 @@
#include "base/logging.h"
#include "base/macros.h"
#include "base/message_loop/message_loop.h"
+#include "base/run_loop.h"
#include "base/single_thread_task_runner.h"
+#include "base/threading/thread_task_runner_handle.h"
#include "chrome/browser/chromeos/login/login_manager_test.h"
#include "chrome/browser/chromeos/login/screens/error_screen.h"
#include "chrome/browser/chromeos/login/screens/network_error_view.h"
@@ -93,9 +95,10 @@ class CaptivePortalWindowTest : public InProcessBrowserTest {
void TearDownOnMainThread() override {
captive_portal_window_proxy_.reset();
- base::MessageLoopForUI::current()->task_runner()->DeleteSoon(FROM_HERE,
- host_);
- base::MessageLoopForUI::current()->RunUntilIdle();
+
+ ASSERT_TRUE(base::MessageLoopForUI::IsCurrent());
+ base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, host_);
+ base::RunLoop().RunUntilIdle();
}
private:

Powered by Google App Engine
This is Rietveld 408576698