Remove calls to MessageLoop(ForUI|ForIO)::Run/RunUntilIdle.

Remove calls to MessageLoop(ForUI|ForIO)::Run/RunUntilIdle.

This CL makes the following replacements:

1.
base::MessageLoopForUIorIO::current()->Run()/RunUntilIdle();
becomes
// This ASSERT_TRUE replaces the DCHECK in
// MessageLoopForUIorIO::current().
ASSERT_TRUE(base::MessageLoopForUIorIO::IsCurrent());
base::RunLoop().Run()/RunUntilIdle();

2.
message_loop_for_ui_or_io.Run()/RunUntilIdle();
becomes
// The ASSERT_TRUE is present only if it isn't obvious that
// the current thread runs a MessageLoopForUIorIO (e.g.
// because it isn't instantiated in the current file).
ASSERT_TRUE(base::MessageLoopForUIorIO::IsCurrent());
base::RunLoop().Run()/RunUntilIdle();

BUG=616447
Committed: https://crrev.com/c5e45f6b0a71c2a174bea1219f9a6709191fde50
Cr-Commit-Position: refs/heads/master@{#420342}

[fdoray, 2016-09-21 16:25:38]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 16:26:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-09-21 16:46:06]

Description was changed from

==========
Remove calls to MessageLoop::Run/RunUntilIdle.

BUG=616447
==========

to

==========
Remove calls to MessageLoop(ForUI|ForIO)::Run/RunUntilIdle.

This CL makes the following replacements:

1.
base::MessageLoopForUIorIO::current()->Run()/RunUntilIdle();
becomes
// This EXPECT_TRUE replaces the DCHECK in
// MessageLoopForUIorIO::current().
EXPECT_TRUE(base::MessageLoopForUIorIO::IsCurrent());
base::RunLoop().Run()/RunUntilIdle();

2.
message_loop_for_ui_or_io.Run()/RunUntilIdle();
becomes
// The EXPECT_TRUE is present only if it isn't obvious that
// the current thread runs a MessageLoopForUIorIO (e.g.
// because it isn't instantiated in the current file).
EXPECT_TRUE(base::MessageLoopForUIorIO::IsCurrent());
base::RunLoop().Run()/RunUntilIdle();

BUG=616447
==========

[fdoray, 2016-09-21 16:48:56]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[fdoray, 2016-09-21 16:49:33]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org

[fdoray, 2016-09-21 16:49:34]

gab@: PTAL
After this, I'll be able to remove MessageLoopForUIorIO::Run/RunUntilIdle.

[commit-bot: I haz the power, 2016-09-21 16:49:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-09-21 17:06:03]

lgtm % comments

https://codereview.chromium.org/2354333002/diff/40001/chrome/browser/spellche...
File
chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc
(right):

https://codereview.chromium.org/2354333002/diff/40001/chrome/browser/spellche...
chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc:26:
TestingSpellCheckMessageFilter(const base::Closure& quit_closure)
explicit

https://codereview.chromium.org/2354333002/diff/40001/chrome/browser/spellche...
chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc:57:
EXPECT_TRUE(base::MessageLoopForUI::IsCurrent());
It's expected that the main body of a test run in the main/UI thread and as such
I don't think this needs to be tested here.

[groby-ooo-7-16, 2016-09-21 17:25:45]

On 2016/09/21 17:06:03, gab wrote:
> lgtm % comments
> 
>
https://codereview.chromium.org/2354333002/diff/40001/chrome/browser/spellche...
> File
>
chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc
> (right):
> 
>
https://codereview.chromium.org/2354333002/diff/40001/chrome/browser/spellche...
>
chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc:26:
> TestingSpellCheckMessageFilter(const base::Closure& quit_closure)
> explicit
> 
>
https://codereview.chromium.org/2354333002/diff/40001/chrome/browser/spellche...
>
chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc:57:
> EXPECT_TRUE(base::MessageLoopForUI::IsCurrent());
> It's expected that the main body of a test run in the main/UI thread and as
such
> I don't think this needs to be tested here.

Sorry, drive-by comment... I'd recomment using ASSERT_TRUE instead of
EXPECT_TRUE. There's no point continuing the test if it's in the wrong thread.
ASSERT will save you from a bunch of additional (likely not helpful) log spew.

[fdoray, 2016-09-21 17:41:44]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 17:41:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fdoray, 2016-09-21 17:46:52]

fdoray@chromium.org changed reviewers:
+ dcheng@chromium.org, groby@chromium.org, pastarmovj@chromium.org,
xiyuan@chromium.org

[fdoray, 2016-09-21 17:46:53]

dcheng@: Please review changes in base/

xiyuan@: Please review changes in chrome/browser/chromeos/

groby@: Please review changes in chrome/browser/spellchecker/

pastarmovj@: Please review changes in components/policy/

Thanks!

https://codereview.chromium.org/2354333002/diff/40001/chrome/browser/spellche...
File
chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc
(right):

https://codereview.chromium.org/2354333002/diff/40001/chrome/browser/spellche...
chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc:26:
TestingSpellCheckMessageFilter(const base::Closure& quit_closure)
On 2016/09/21 17:06:03, gab wrote:
> explicit

Done.

https://codereview.chromium.org/2354333002/diff/40001/chrome/browser/spellche...
chrome/browser/spellchecker/spellcheck_message_filter_platform_mac_browsertest.cc:57:
EXPECT_TRUE(base::MessageLoopForUI::IsCurrent());
On 2016/09/21 17:06:03, gab wrote:
> It's expected that the main body of a test run in the main/UI thread and as
such
> I don't think this needs to be tested here.

Done.

[groby-ooo-7-16, 2016-09-21 17:52:06]

spellcheck LGTM

https://codereview.chromium.org/2354333002/diff/60001/components/policy/core/...
File components/policy/core/common/policy_loader_mac_unittest.cc (right):

https://codereview.chromium.org/2354333002/diff/60001/components/policy/core/...
components/policy/core/common/policy_loader_mac_unittest.cc:180:
EXPECT_TRUE(base::MessageLoopForIO::IsCurrent());
You currently assert in some files, and expect in others - you probably want a
consistent style :)

[xiyuan, 2016-09-21 18:03:12]

https://codereview.chromium.org/2354333002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc
(left):

https://codereview.chromium.org/2354333002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc:203:
loop_.RunUntilIdle();
This seems intentional to make sure all background jobs are cleared. Would the
change break the test?

[fdoray, 2016-09-21 18:04:28]

Description was changed from

==========
Remove calls to MessageLoop(ForUI|ForIO)::Run/RunUntilIdle.

This CL makes the following replacements:

1.
base::MessageLoopForUIorIO::current()->Run()/RunUntilIdle();
becomes
// This EXPECT_TRUE replaces the DCHECK in
// MessageLoopForUIorIO::current().
EXPECT_TRUE(base::MessageLoopForUIorIO::IsCurrent());
base::RunLoop().Run()/RunUntilIdle();

2.
message_loop_for_ui_or_io.Run()/RunUntilIdle();
becomes
// The EXPECT_TRUE is present only if it isn't obvious that
// the current thread runs a MessageLoopForUIorIO (e.g.
// because it isn't instantiated in the current file).
EXPECT_TRUE(base::MessageLoopForUIorIO::IsCurrent());
base::RunLoop().Run()/RunUntilIdle();

BUG=616447
==========

to

==========
Remove calls to MessageLoop(ForUI|ForIO)::Run/RunUntilIdle.

This CL makes the following replacements:

1.
base::MessageLoopForUIorIO::current()->Run()/RunUntilIdle();
becomes
// This ASSERT_TRUE replaces the DCHECK in
// MessageLoopForUIorIO::current().
ASSERT_TRUE(base::MessageLoopForUIorIO::IsCurrent());
base::RunLoop().Run()/RunUntilIdle();

2.
message_loop_for_ui_or_io.Run()/RunUntilIdle();
becomes
// The ASSERT_TRUE is present only if it isn't obvious that
// the current thread runs a MessageLoopForUIorIO (e.g.
// because it isn't instantiated in the current file).
ASSERT_TRUE(base::MessageLoopForUIorIO::IsCurrent());
base::RunLoop().Run()/RunUntilIdle();

BUG=616447
==========

[fdoray, 2016-09-21 18:08:01]

dcheng@: Please review changes in base/

xiyuan@: Please review changes in chrome/browser/chromeos/

groby@: Thanks!

pastarmovj@: Please review changes in components/policy/

https://codereview.chromium.org/2354333002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc
(left):

https://codereview.chromium.org/2354333002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc:203:
loop_.RunUntilIdle();
On 2016/09/21 18:03:11, xiyuan wrote:
> This seems intentional to make sure all background jobs are cleared. Would the
> change break the test?

RunUntilIdle() runs tasks until the queue of tasks that are ready to run is
empty. If you call it twice in a row, it's unlikely that the second call will
run tasks (if it does, it means that a delay has expired or that a task was
posted between the two calls).

https://codereview.chromium.org/2354333002/diff/60001/components/policy/core/...
File components/policy/core/common/policy_loader_mac_unittest.cc (right):

https://codereview.chromium.org/2354333002/diff/60001/components/policy/core/...
components/policy/core/common/policy_loader_mac_unittest.cc:180:
EXPECT_TRUE(base::MessageLoopForIO::IsCurrent());
On 2016/09/21 17:52:05, groby wrote:
> You currently assert in some files, and expect in others - you probably want a
> consistent style :) 

Done. ASSERT everywhere.

[xiyuan, 2016-09-21 18:18:23]

c/b/chromeos lgtm

https://codereview.chromium.org/2354333002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc
(left):

https://codereview.chromium.org/2354333002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos_unittest.cc:203:
loop_.RunUntilIdle();
On 2016/09/21 18:08:01, fdoray wrote:
> On 2016/09/21 18:03:11, xiyuan wrote:
> > This seems intentional to make sure all background jobs are cleared. Would
the
> > change break the test?
> 
> RunUntilIdle() runs tasks until the queue of tasks that are ready to run is
> empty. If you call it twice in a row, it's unlikely that the second call will
> run tasks (if it does, it means that a delay has expired or that a task was
> posted between the two calls).

Okay. Looks like the test passes on trybots.

[dcheng, 2016-09-22 00:40:38]

base LGTM

[pastarmovj, 2016-09-22 08:18:11]

policy lgtm

[fdoray, 2016-09-22 12:00:15]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-09-22 12:00:15]

The patchset sent to the CQ was uploaded after l-g-t-m from gab@chromium.org,
groby@chromium.org
Link to the patchset: https://codereview.chromium.org/2354333002/#ps80001
(title: "CR groby #15 EXPECT -> ASSERT")

[commit-bot: I haz the power, 2016-09-22 12:00:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 12:56:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 12:56:47]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[fdoray, 2016-09-22 13:34:37]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-09-22 13:34:38]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
gab@chromium.org, pastarmovj@chromium.org, dcheng@chromium.org,
groby@chromium.org
Link to the patchset: https://codereview.chromium.org/2354333002/#ps100001
(title: "fix build error")

[commit-bot: I haz the power, 2016-09-22 13:34:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 15:06:27]

Description was changed from

==========
Remove calls to MessageLoop(ForUI|ForIO)::Run/RunUntilIdle.

This CL makes the following replacements:

1.
base::MessageLoopForUIorIO::current()->Run()/RunUntilIdle();
becomes
// This ASSERT_TRUE replaces the DCHECK in
// MessageLoopForUIorIO::current().
ASSERT_TRUE(base::MessageLoopForUIorIO::IsCurrent());
base::RunLoop().Run()/RunUntilIdle();

2.
message_loop_for_ui_or_io.Run()/RunUntilIdle();
becomes
// The ASSERT_TRUE is present only if it isn't obvious that
// the current thread runs a MessageLoopForUIorIO (e.g.
// because it isn't instantiated in the current file).
ASSERT_TRUE(base::MessageLoopForUIorIO::IsCurrent());
base::RunLoop().Run()/RunUntilIdle();

BUG=616447
==========

to

==========
Remove calls to MessageLoop(ForUI|ForIO)::Run/RunUntilIdle.

This CL makes the following replacements:

1.
base::MessageLoopForUIorIO::current()->Run()/RunUntilIdle();
becomes
// This ASSERT_TRUE replaces the DCHECK in
// MessageLoopForUIorIO::current().
ASSERT_TRUE(base::MessageLoopForUIorIO::IsCurrent());
base::RunLoop().Run()/RunUntilIdle();

2.
message_loop_for_ui_or_io.Run()/RunUntilIdle();
becomes
// The ASSERT_TRUE is present only if it isn't obvious that
// the current thread runs a MessageLoopForUIorIO (e.g.
// because it isn't instantiated in the current file).
ASSERT_TRUE(base::MessageLoopForUIorIO::IsCurrent());
base::RunLoop().Run()/RunUntilIdle();

BUG=616447
==========

[commit-bot: I haz the power, 2016-09-22 15:06:29]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-22 15:08:43]

Description was changed from

==========
Remove calls to MessageLoop(ForUI|ForIO)::Run/RunUntilIdle.

This CL makes the following replacements:

1.
base::MessageLoopForUIorIO::current()->Run()/RunUntilIdle();
becomes
// This ASSERT_TRUE replaces the DCHECK in
// MessageLoopForUIorIO::current().
ASSERT_TRUE(base::MessageLoopForUIorIO::IsCurrent());
base::RunLoop().Run()/RunUntilIdle();

2.
message_loop_for_ui_or_io.Run()/RunUntilIdle();
becomes
// The ASSERT_TRUE is present only if it isn't obvious that
// the current thread runs a MessageLoopForUIorIO (e.g.
// because it isn't instantiated in the current file).
ASSERT_TRUE(base::MessageLoopForUIorIO::IsCurrent());
base::RunLoop().Run()/RunUntilIdle();

BUG=616447
==========

to

==========
Remove calls to MessageLoop(ForUI|ForIO)::Run/RunUntilIdle.

This CL makes the following replacements:

1.
base::MessageLoopForUIorIO::current()->Run()/RunUntilIdle();
becomes
// This ASSERT_TRUE replaces the DCHECK in
// MessageLoopForUIorIO::current().
ASSERT_TRUE(base::MessageLoopForUIorIO::IsCurrent());
base::RunLoop().Run()/RunUntilIdle();

2.
message_loop_for_ui_or_io.Run()/RunUntilIdle();
becomes
// The ASSERT_TRUE is present only if it isn't obvious that
// the current thread runs a MessageLoopForUIorIO (e.g.
// because it isn't instantiated in the current file).
ASSERT_TRUE(base::MessageLoopForUIorIO::IsCurrent());
base::RunLoop().Run()/RunUntilIdle();

BUG=616447

Committed: https://crrev.com/c5e45f6b0a71c2a174bea1219f9a6709191fde50
Cr-Commit-Position: refs/heads/master@{#420342}
==========

[commit-bot: I haz the power, 2016-09-22 15:08:45]

Patchset 6 (id:??) landed as
https://crrev.com/c5e45f6b0a71c2a174bea1219f9a6709191fde50
Cr-Commit-Position: refs/heads/master@{#420342}