Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2354323003: Set minimal width for the username in the password bubble on Mac. (Closed)

Created:
4 years, 3 months ago by vasilii
Modified:
4 years, 3 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set minimal width for the username in the password bubble on Mac. BUG=648831 Committed: https://crrev.com/ea08f0cc6410d6a6fb0a813eca66aa4fdc36242b Cr-Commit-Position: refs/heads/master@{#420393}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/passwords/passwords_bubble_utils.mm View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
vasilii
Hi Vaclav, please review.
4 years, 3 months ago (2016-09-22 15:50:54 UTC) #4
vabr (Chromium)
LGTM, thanks! Vaclav
4 years, 3 months ago (2016-09-22 15:53:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354323003/1
4 years, 3 months ago (2016-09-22 16:53:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/301141)
4 years, 3 months ago (2016-09-22 17:38:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354323003/1
4 years, 3 months ago (2016-09-22 17:40:55 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-22 18:03:44 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 18:07:06 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea08f0cc6410d6a6fb0a813eca66aa4fdc36242b
Cr-Commit-Position: refs/heads/master@{#420393}

Powered by Google App Engine
This is Rietveld 408576698