Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2354303002: dscache: Use math/rand's Read for nonce. (Closed)

Created:
4 years, 3 months ago by dnj
Modified:
4 years, 3 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

dscache: Use math/rand's Read for nonce. Fixes #55. BUG=None TEST=None Committed: https://github.com/luci/gae/commit/cfd4c03f8de6f353360064aca2d2fcf517bedf8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -23 lines) Patch
M filter/dscache/dscache.go View 1 chunk +2 lines, -2 lines 0 comments Download
M filter/dscache/support.go View 3 chunks +12 lines, -21 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
dnj
PTAL
4 years, 3 months ago (2016-09-21 16:15:09 UTC) #4
iannucci
lgtm
4 years, 3 months ago (2016-09-21 16:29:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354303002/1
4 years, 3 months ago (2016-09-21 16:44:05 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 16:47:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/cfd4c03f8de6f353360064aca2d2fcf517bedf8b

Powered by Google App Engine
This is Rietveld 408576698