Make Transform a little more pleasant to use:

pkg/barback/test/transformer/mock.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library barback.test.transformer.mock;
 
 import 'dart:async';
 
 import 'package:barback/barback.dart';
 import 'package:barback/src/utils.dart';
@@ skipping 12 matching lines @@
   /// The number of times the transformer has been applied.
   ///
   /// This is scheduled. The Future will complete at the point in the schedule
   /// that this is called.
   Future<int> get numRuns => schedule(() => _numRuns);
   var _numRuns = 0;
 
   /// The number of currently running transforms.
   int _runningTransforms = 0;
 
-  // A completer for pausing the transformer before it finishes running [apply].
+  /// A completer for pausing the transformer before it finishes running [apply].
   Completer _apply;
 
-  // Completers for pausing the transformer before it finishes running
-  // [isPrimary].
+  /// Completers for pausing the transformer before it finishes running
+  /// [isPrimary].
   final _isPrimary = new Map<AssetId, Completer>();
 
-  // Completers for pausing the transformer before it finishes getting inputs
-  // the [Transform].
+  /// Completers for pausing the transformer before it finishes getting inputs
+  /// the [Transform].
   final _getInput = new Map<AssetId, Completer>();
 
+  /// Completer for pausing the transformer before it accesses [primaryInput].
+  Completer _getPrimary;
+
   /// A completer that completes once this transformer begins running.
   ///
   /// Once this transformer finishes running, this is reset to a new completer,
   /// so it can be used multiple times.
   var _started = new Completer();
 
   /// `true` if any transforms are currently running.
   ///
   /// This is scheduled. The Future will complete at the point in the schedule
   /// that this is called.
@@ skipping 38 matching lines @@
   /// Resumes the transformer's [isPrimary] call on the asset with the given
   /// [name] after [pauseIsPrimary] was called.
   ///
   /// This operation is scheduled.
   void resumeIsPrimary(String name) {
     schedule(() {
       _isPrimary.remove(new AssetId.parse(name)).complete();
     }, "resume isPrimary($name) for $this");
   }
 
-  /// Causes the transformer to pause while loading the input with the given
-  /// [name]. This can be the primary input or a secondary input.
+  /// Causes the transformer to pause while loading the secondary input with
+  /// the given [name].
   ///
   /// This can be resumed by calling [resumeGetInput]. This operation is
   /// scheduled.
   void pauseGetInput(String name) {
     schedule(() {
       _getInput[new AssetId.parse(name)] = new Completer();
     }, "pause getInput($name) for $this");
   }
 
   /// Resumes the transformer's loading of the input with the given [name] after
   /// [pauseGetInput] was called.
   ///
   /// This operation is scheduled.
   void resumeGetInput(String name) {
     schedule(() {
       _getInput.remove(new AssetId.parse(name)).complete();
     }, "resume getInput($name) for $this");
   }
 
+  /// Causes the transformer to pause before accessing [primaryInput].
+  ///
+  /// This can be resumed by calling [resumeGetPrimary]. This operation is
+  /// scheduled.
+  void pauseGetPrimary() {

[nweiz, 2013/08/28 21:15:00]

I don't like making these separate from [pauseGetInput] and [resumeGetInput].
They're visually difficult to distinguish from {pause,resume}IsPrimary, and they
mean that calling `pauseGetInput(primaryId)` won't work as expected.

[Bob Nystrom, 2013/08/28 22:38:24]

I think it's important to split this out. This method hits the primaryInput
getter where getInput() does not. I want coverage on that codepath. I could make
pauseInput() check the ID and call primaryInput if the ID is the primary one,
but I think that obscures the intent of the tests.

I renamed the methods to pausePrimaryInput() and resumePrimaryInput() to be a
bit more distinct.

+    schedule(() {
+      _getPrimary = new Completer();
+    }, "pause primaryInput for $this");
+  }
+
+  /// Resumes the transformer's invocation of [primaryInput] after
+  /// [pauseGetPrimary] was called.
+  ///
+  /// This operation is scheduled.
+  void resumeGetPrimary() {
+    schedule(() {
+      _getPrimary.complete();
+      _getPrimary = null;
+    }, "resume getPrimary() for $this");
+  }
+
   /// Like [Transform.getInput], but respects [pauseGetInput].
   ///
   /// This is intended for use by subclasses of [MockTransformer].
   Future<Asset> getInput(Transform transform, AssetId id) {
     return newFuture(() {
       if (_getInput.containsKey(id)) return _getInput[id].future;
     }).then((_) => transform.getInput(id));
   }
 
-  /// Like [Transform.primaryInput], but respects [pauseGetInput].
+  /// Like [Transform.primaryInput], but respects [pauseGetPrimary].
   ///
   /// This is intended for use by subclasses of [MockTransformer].
-  Future<Asset> getPrimary(Transform transform) =>
-      getInput(transform, transform.primaryId);
+  Future<Asset> getPrimary(Transform transform) {
+    return newFuture(() {
+      if (_getPrimary != null) return _getPrimary.future;
+    }).then((_) => transform.primaryInput);
+  }
 
   Future<bool> isPrimary(Asset asset) {
     return newFuture(() => doIsPrimary(asset)).then((result) {
       return newFuture(() {
         if (_isPrimary.containsKey(asset.id)) {
           return _isPrimary[asset.id].future;
         }
       }).then((_) => result);
     });
   }
 
   Future apply(Transform transform) {
     _numRuns++;
     if (_runningTransforms == 0) _started.complete();
     _runningTransforms++;
     return newFuture(() => doApply(transform)).then((_) {
       if (_apply != null) return _apply.future;
     }).whenComplete(() {
       _runningTransforms--;
       if (_runningTransforms == 0) _started = new Completer();
     });
   }
 
   /// The wrapped version of [isPrimary] for subclasses to override.
   Future<bool> doIsPrimary(Asset asset);
 
   /// The wrapped version of [doApply] for subclasses to override.
   Future doApply(Transform transform);
 }