Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 2354283002: Drop the SVGLengthType enumeration (Closed)

Created:
4 years, 2 months ago by fs
Modified:
4 years, 2 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop the SVGLengthType enumeration After the transition to using CSSPrimitiveValue, this enumeration is not used by anything but the DOM-side of SVGLength (SVGLengthTearOff), and for that we might as well use the interface constants directly. The LengthTypeREMS and LengthTypeCHS values are dropped entirely because they are not referenced by anything. Committed: https://crrev.com/38aa09164eb92a9f1afc40ac79c5720515822199 Cr-Commit-Position: refs/heads/master@{#420150}

Patch Set 1 #

Patch Set 2 : Drop the enum entirely #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -45 lines) Patch
M third_party/WebKit/Source/core/svg/SVGLengthContext.h View 1 chunk +0 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLengthTearOff.h View 1 3 chunks +12 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp View 1 2 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
fs
4 years, 2 months ago (2016-09-21 18:15:58 UTC) #7
pdr.
On 2016/09/21 at 18:15:58, fs wrote: > LGTM
4 years, 2 months ago (2016-09-21 20:03:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354283002/20001
4 years, 2 months ago (2016-09-21 20:15:58 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-21 20:22:22 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-21 20:24:27 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/38aa09164eb92a9f1afc40ac79c5720515822199
Cr-Commit-Position: refs/heads/master@{#420150}

Powered by Google App Engine
This is Rietveld 408576698