Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2354263006: Freeze scrollbars for relayout if overflow:auto added scrollbars. (Closed)

Created:
4 years, 3 months ago by szager1
Modified:
4 years, 3 months ago
Reviewers:
cbiesinger, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Freeze scrollbars for relayout if overflow:auto added scrollbars. Under very specific circumstances, LayoutBlockFlow::layoutBlock will loop infinitely in this stanza: while (!done) done = layoutBlockFlow(...); ... due to fluctuations in the existence of overflow:auto scrollbars in descendants. Any layout type that does multi-pass layout is especially susceptible to this, hence this bug affecting flexbox, and another recent bug affecting tables: crbug.com/64635. This fix supercedes the existing fix for the table bug, and it should fix any other variations of this bug involving multi-pass layout and overflow:auto. Cherry-picked from https://codereview.chromium.org/2345103002 BUG=644450 TBR=cbiesinger@chromium.org,eae@chromium.org NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/scrollbars/overflow-auto-infinite-loop.html View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
szager1
4 years, 3 months ago (2016-09-23 04:49:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354263006/1
4 years, 3 months ago (2016-09-23 04:50:16 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-09-23 04:54:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698