[inspector] add presubmit.py to compile inspector-related scripts

src/inspector/PRESUBMIT.py

+#!/usr/bin/env python
+#
+# Copyright 2016 the V8 project authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""v8_inspect presubmit script
+
+See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
+for more details about the presubmit API built into gcl.
+"""
+
+compile_note = "Be sure to run your patch by the compile-scripts.py script prior to committing!"
+
+
+def _CompileScripts(input_api, output_api):
+    local_paths = [f.LocalPath() for f in input_api.AffectedFiles()]

[Michael Achenbach, 2016/09/28 09:54:04]

nit: two space indents.

[kozy, 2016/09/28 23:38:46]

Done.

+    if (any("js_protocol.json" in path for path in local_paths) or

[Michael Achenbach, 2016/09/28 09:54:04]

nit: too much indentation.

[kozy, 2016/09/28 23:38:46]

Done.

+            any("compile-scripts.py" in path for path in local_paths) or
+            any("injected-script-source.js" in path for path in local_paths) or
+            any("debugger_script_externs.js" in path for path in local_paths) or
+            any("injected_script_externs.js" in path for path in local_paths) or
+            any("check_injected_script_source.js" in path for path in local_paths) or
+            any("debugger-script.js" in path for path in local_paths)):

[Michael Achenbach, 2016/09/28 09:54:04]

Can you maybe rewrite this with less duplication? E.g. one flat list of files
that gets processed by the same code?

[kozy, 2016/09/28 23:38:46]

Done.

+        lint_path = input_api.os_path.join(input_api.PresubmitLocalPath(),

[Michael Achenbach, 2016/09/28 09:54:04]

nit: Is lint an appropriate name in this context?

[kozy, 2016/09/28 23:38:46]

Done.

+            "build", "compile-scripts.py")
+        out, _ = input_api.subprocess.Popen(
+            [input_api.python_executable, lint_path],
+            stdout=input_api.subprocess.PIPE,
+            stderr=input_api.subprocess.STDOUT).communicate()
+        if "ERROR" in out or "WARNING" in out:

[Michael Achenbach, 2016/09/28 09:54:04]

How about also checking the return code of the process? Needs a local variable
of the popen result. Not that it failed with an error and no output.

[kozy, 2016/09/28 23:38:46]

Done.

+            return [output_api.PresubmitError(out)]
+        if "NOTE" in out:
+            return [output_api.PresubmitPromptWarning(out + compile_note)]
+    return []
+
+
+def CheckChangeOnUpload(input_api, output_api):
+    results = []
+    results.extend(_CompileScripts(input_api, output_api))
+    return results
+
+
+def CheckChangeOnCommit(input_api, output_api):
+    results = []

[Michael Achenbach, 2016/09/28 09:54:05]

Why not on commit? We'd like the CQ to actually ensure this, especially if folks
bypass hooks on upload.

[dgozman, 2016/09/28 13:50:32]

AFAIU, commit hooks are run on bots, which require them to have Java. Our team
member is working on enabling this for DevTools frontend on Chromium bots now,
but it's not finished yet.

[Michael Achenbach, 2016/09/28 14:27:27]

Just checked a random bot that runs our presubmit and it has java. And as I
understood, this auto-detects if java is installed and just does nothing if it
isn't?

[kozy, 2016/09/28 23:38:46]

Added for commit.

+    return results