Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(923)

Issue 23542060: Use GL_TEXTURE_2D for pixel readback path in GpuVideoAcceleratorFactories (Closed)

Created:
7 years, 3 months ago by sheu
Modified:
7 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, wjia+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@git-svn
Visibility:
Public.

Description

Use GL_TEXTURE_2D for pixel readback path in GpuVideoAcceleratorFactories Using the destination texture target in GpuVideoAcceleratorFactores::ReadPixels is incorrect, as the temporary texture should always be GL_TEXTURE_2D. BUG=None TEST=local build, run on CrOS snow, unittests on desktop Linux Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225379

Patch Set 1 #

Patch Set 2 : 96ed822d Initial. #

Patch Set 3 : 58c9bd02 git cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -20 lines) Patch
M content/renderer/media/renderer_gpu_video_accelerator_factories.h View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M content/renderer/media/renderer_gpu_video_accelerator_factories.cc View 4 chunks +8 lines, -11 lines 0 comments Download
M content/renderer/media/rtc_video_decoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/gpu_video_accelerator_factories.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/mock_gpu_video_accelerator_factories.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sheu
Tested with webgl video texture demos as well. fischman@: PTAL
7 years, 3 months ago (2013-09-24 19:56:16 UTC) #1
Ami GONE FROM CHROMIUM
LGTM AFAIK but this isn't very far. How does copyTextureCHROMIUM know which target texture_id refers ...
7 years, 3 months ago (2013-09-24 20:07:30 UTC) #2
sheu
AFAICT the "target" parameter to copyTextureCHROMIUM is essentially vestigial. The texture targets for the source ...
7 years, 3 months ago (2013-09-24 21:00:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheu@chromium.org/23542060/7001
7 years, 2 months ago (2013-09-25 18:30:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sheu@chromium.org/23542060/7001
7 years, 2 months ago (2013-09-25 21:27:34 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-09-26 07:38:14 UTC) #6
Message was sent while issue was closed.
Change committed as 225379

Powered by Google App Engine
This is Rietveld 408576698