Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 23542041: Make "as" a built-in identifier aka pseudo keyword (Closed)

Created:
7 years, 3 months ago by hausner
Modified:
7 years, 3 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Make "as" a built-in identifier aka pseudo keyword Fixes issues 12551, 13021 R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=27461

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -22 lines) Patch
M runtime/vm/intermediate_language.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier.h View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/vm/parser.cc View 3 chunks +7 lines, -10 lines 0 comments Download
M runtime/vm/token.h View 2 chunks +2 lines, -4 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
hausner
7 years, 3 months ago (2013-09-12 23:38:40 UTC) #1
regis
LGTM
7 years, 3 months ago (2013-09-12 23:42:47 UTC) #2
hausner
7 years, 3 months ago (2013-09-12 23:45:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27461 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698