Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 23542027: Don't align size on allocation granularity for unaligned ReserveRegion calls. (Closed)

Created:
7 years, 3 months ago by Benedikt Meurer
Modified:
7 years, 3 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Don't align size on allocation granularity for unaligned ReserveRegion calls. Also add additional ASSERTs to help tracking the flaky test-alloc/CodeRange in Windows. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16648

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/platform/virtual-memory.cc View 4 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
Hey Toon, This is a followup fix for the VirtualMemory cleanup. PTAL -- Benedikt
7 years, 3 months ago (2013-09-11 11:11:36 UTC) #1
Toon Verwaest
lgtm
7 years, 3 months ago (2013-09-11 11:29:44 UTC) #2
Benedikt Meurer
7 years, 3 months ago (2013-09-11 11:33:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r16648 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698