Explicit space required around NOT/ONLY/AND in CSS MQ.

Explicit space required around NOT/ONLY/AND in CSS MQ.

The Media Queries errata[1] dated 2013-08-30 changes from S* to S+ around
NOT, ONLY, and AND tokens. In practice, it means these tokens cannot be
separated from other tokens using comments alone anymore.

[1] http://www.w3.org/Style/2012/REC-mediaqueries-20120619-errata.html

BUG=288803
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158717

[SeRya, 2013-09-23 09:12:43]

https://codereview.chromium.org/23542021/diff/1/Source/core/css/CSSGrammar.y.in
File Source/core/css/CSSGrammar.y.in (right):

https://codereview.chromium.org/23542021/diff/1/Source/core/css/CSSGrammar.y....
Source/core/css/CSSGrammar.y.in:402: spaces:
It should be 'space' for consistency with 'maybe_space'.

I see only way to get 2 or more sequential whitespaces is putting comments
between them. This grammar uses the token WHITESPACE several times. I guess that
places won't accept comments.

https://codereview.chromium.org/23542021/diff/1/Source/core/css/CSSGrammar.y....
Source/core/css/CSSGrammar.y.in:630: media_query_exp_list_space:
Can "media_query_exp_list_space" be replaced by "media_query_exp_list_no_space
spaces" and "media_query_exp_list" by "media_query_exp_list_no_space
maybe_space"?

If so only one entity of 3 is really needed.

https://codereview.chromium.org/23542021/diff/1/Source/core/css/CSSGrammar.y....
Source/core/css/CSSGrammar.y.in:643: | spaces {
maybe_space {
    ....
}

To avoid conflicts redefine maybe_space through space:

maybe_space: /* empty */ | space.

[rune, 2013-10-01 12:04:48]

https://codereview.chromium.org/23542021/diff/1/Source/core/css/CSSGrammar.y.in
File Source/core/css/CSSGrammar.y.in (right):

https://codereview.chromium.org/23542021/diff/1/Source/core/css/CSSGrammar.y....
Source/core/css/CSSGrammar.y.in:402: spaces:
On 2013/09/23 09:12:43, SeRya wrote:
> It should be 'space' for consistency with 'maybe_space'.

Done.

> I see only way to get 2 or more sequential whitespaces is putting comments
> between them. This grammar uses the token WHITESPACE several times. I guess
that
> places won't accept comments.

The required WHITESPACE after @region and @filter are clearly mistakes. I've
replaced them with maybe_space like other @-rules use.

The use of WHITESPACE in descendant selectors works, so I haven't changed that.

The WHITESPACE in calc-expressions didn't allow comments with spaces on both
sides which the spec allows, AFAICT. Also, Gecko supports comments there, so
I've replaced WHITESPACE with "space".

https://codereview.chromium.org/23542021/diff/1/Source/core/css/CSSGrammar.y....
Source/core/css/CSSGrammar.y.in:630: media_query_exp_list_space:
On 2013/09/23 09:12:43, SeRya wrote:
> Can "media_query_exp_list_space" be replaced by "media_query_exp_list_no_space
> spaces" and "media_query_exp_list" by "media_query_exp_list_no_space
> maybe_space"?
> 
> If so only one entity of 3 is really needed.

Done. I've removed the _no_space part since there's now only one non-terminal
left.

https://codereview.chromium.org/23542021/diff/1/Source/core/css/CSSGrammar.y....
Source/core/css/CSSGrammar.y.in:643: | spaces {
On 2013/09/23 09:12:43, SeRya wrote:
> maybe_space {
>     ....
> }
> 
> To avoid conflicts redefine maybe_space through space:
> 
> maybe_space: /* empty */ | space.

Done.

[SeRya, 2013-10-01 13:41:35]

https://codereview.chromium.org/23542021/diff/11001/Source/core/css/CSSGramma...
File Source/core/css/CSSGrammar.y.in (right):

https://codereview.chromium.org/23542021/diff/11001/Source/core/css/CSSGramma...
Source/core/css/CSSGrammar.y.in:629: /*empty*/ {
"maybe_space" instead of "/*empty*/ | space".

The rest looks good.

[rune, 2013-10-01 13:59:53]

https://codereview.chromium.org/23542021/diff/11001/Source/core/css/CSSGramma...
File Source/core/css/CSSGrammar.y.in (right):

https://codereview.chromium.org/23542021/diff/11001/Source/core/css/CSSGramma...
Source/core/css/CSSGrammar.y.in:629: /*empty*/ {
On 2013/10/01 13:41:35, SeRya wrote:
> "maybe_space" instead of "/*empty*/ | space".
> 
> The rest looks good.

Done.

[SeRya, 2013-10-01 15:23:27]

lgtm

[apavlov, 2013-10-02 11:08:28]

lgtm

[commit-bot: I haz the power, 2013-10-02 11:08:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rune@opera.com/23542021/23001

[commit-bot: I haz the power, 2013-10-02 12:29:22]

Change committed as 158717

[rune, 2013-10-02 20:28:51]

On 2013/10/01 15:23:27, SeRya wrote:
> lgtm

The other WHITESPACE fixes were split out as a separate CL on request from
apavlov:

https://codereview.chromium.org/25607005/