chrome/test/chromedriver/chrome/automation_extension.cc - Issue 23542015: [chromedriver] Fallback to devtools for screenshotting of forbidden urls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/automation_extension.cc

Issue 23542015: [chromedriver] Fallback to devtools for screenshotting of forbidden urls. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/automation_extension.h ('k') | chrome/test/chromedriver/chrome/status.h » ('j') | chrome/test/chromedriver/window_commands.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/automation_extension.cc

diff --git a/chrome/test/chromedriver/chrome/automation_extension.cc b/chrome/test/chromedriver/chrome/automation_extension.cc

index 27999c8b85fb2c7a3f4bb1be407d6004f2ca6537..1a120a182233919eb7c83f9d288133c8961ce94e 100644

--- a/chrome/test/chromedriver/chrome/automation_extension.cc

+++ b/chrome/test/chromedriver/chrome/automation_extension.cc

@@ -24,7 +24,7 @@ Status AutomationExtension::CaptureScreenshot(std::string* screenshot) {

base::TimeDelta::FromSeconds(10),

&result);

if (status.IsError())

- return Status(kUnknownError, "cannot take screenshot", status);

+ return Status(status.code(), "cannot take screenshot", status);

if (!result->GetAsString(screenshot))

return Status(kUnknownError, "screenshot is not a string");

return Status(kOk);