Add a CodeToNativeKeycode helper that converts UIEvent code to native code.

ui/base/keycodes/usb_keycode_map.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Data in this file was created by referencing:
 //  USB HID Usage Tables (v1.11) 27 June 2001
 //  HIToolbox/Events.h (Mac)
 
 #include <stdint.h>
 
@@ skipping 381 matching lines @@
   for (size_t i = 0; i < arraysize(usb_keycode_map); ++i) {
     if (usb_keycode_map[i].native_keycode == native_keycode) {
       if (usb_keycode_map[i].code != NULL)
         return usb_keycode_map[i].code;
       break;
     }
   }
   return InvalidKeyboardEventCode();
 }
 
+inline uint16_t CodeToNativeKeycode(const char* code) {
+  if (code) {

[Wez, 2013/09/05 00:16:33]

You don't need this if - the loop will exit on the first iteration if |code| is
NULL.

[Wez, 2013/09/05 00:16:33]

You should explicitly check for "Unidentified" here, and return
InvalidNativeKeycode() in that case, otherwise you scan the entire array only to
find no match.

[weitao, 2013/09/05 07:49:17]

I do need this "if". Otherwise strcmp would crash.

[Wez, 2013/09/05 19:07:02]

Yes, sorry; missed that you're not comparing the ptr value in the loop. ;)

+    // TODO: sort |usb_keycode_map| by |code| so we can use binary search here.

[Wez, 2013/09/05 00:16:33]

This comment assumes that linear search performance won't be sufficient; if you
want to research that, please file a bug rather than adding a comment here. :)

[weitao, 2013/09/05 07:49:17]

Done.

+    for (size_t i = 0; i < arraysize(usb_keycode_map); ++i) {
+      if (usb_keycode_map[i].code && strcmp(usb_keycode_map[i].code, code) == 0)

[Wez, 2013/09/05 00:16:33]

Split this into two if()s for clarity.

[weitao, 2013/09/05 07:49:17]

I feel the purpose of two conditions connected by && is pretty clear; if the
current code is not NULL and it equals the code passed in. The first condition
is necessary because strcmp requires non-NULL arguments.

[Wez, 2013/09/05 19:07:02]

Right - I'm suggesting:

if (!code)
  continue;
if (strcmp)
  return stuff;

+        return usb_keycode_map[i].native_keycode;
+    }
+  }
+  return InvalidNativeKeycode();
+}
+
 // USB keycodes
 // Note that USB keycodes are not part of any web standard.
 // Please don't use USB keycodes in new code.
 
 inline uint16_t InvalidUsbKeycode() {
   return usb_keycode_map[0].usb_keycode;
 }
 
 inline uint16_t UsbKeycodeToNativeKeycode(uint32_t usb_keycode) {
   // Deal with some special-cases that don't fit the 1:1 mapping.
@@ skipping 19 matching lines @@
   return InvalidUsbKeycode();
 }
 
 inline const char* UsbKeycodeToCode(uint32_t usb_keycode) {
   for (size_t i = 0; i < arraysize(usb_keycode_map); ++i) {
     if (usb_keycode_map[i].usb_keycode == usb_keycode)
       return usb_keycode_map[i].code;
   }
   return InvalidKeyboardEventCode();
 }