Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 23542007: ninja: Stop lower-casing outputs on case-insensitive file systems. (Closed)

Created:
7 years, 3 months ago by Nico
Modified:
7 years, 3 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja: Stop lower-casing outputs on case-insensitive file systems. This was added to fix a problem with file renames that rename a file only in captialization (https://chromiumcodereview.appspot.com/10907140). Now that we use depsmode (which reads deps from a flat text file instead of doing a lookup for a depsfile on the file system, and which always does so case-sensitively), this is no longer necessary. The test we added when we added this hack still passes. R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1712

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -18 lines) Patch
M pylib/gyp/generator/ninja.py View 7 chunks +7 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
7 years, 3 months ago (2013-09-01 18:31:34 UTC) #1
scottmg
I kind of liked the lowercase names, but I guess we should stick to provided ...
7 years, 3 months ago (2013-09-03 21:27:58 UTC) #2
Nico
7 years, 3 months ago (2013-09-04 00:30:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1712 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698