Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6133)

Unified Diff: chrome/test/chromedriver/session_commands.cc

Issue 23542005: [chromedriver] Improve timeout behavior. Prompted by user who executes script on busy page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/session_commands.cc
diff --git a/chrome/test/chromedriver/session_commands.cc b/chrome/test/chromedriver/session_commands.cc
index 53b39338eb8f9fa6f3921fc33ff0a5ede31741c3..93bb1ada2833db3c64ed17cef9cab3c897965bd9 100644
--- a/chrome/test/chromedriver/session_commands.cc
+++ b/chrome/test/chromedriver/session_commands.cc
@@ -222,8 +222,7 @@ Status ExecuteSetTimeout(
session->script_timeout = timeout;
} else if (type == "page load") {
session->page_load_timeout =
- ((timeout < base::TimeDelta()) ? base::TimeDelta::FromMilliseconds(
- Session::kDefaultPageLoadTimeoutMs)
+ ((timeout < base::TimeDelta()) ? Session::kDefaultPageLoadTimeout
: timeout);
} else {
return Status(kUnknownError, "unknown type of timeout:" + type);

Powered by Google App Engine
This is Rietveld 408576698