chrome/test/chromedriver/session.h - Issue 23542005: [chromedriver] Improve timeout behavior. Prompted by user who executes script on busy page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/session.h

Issue 23542005: [chromedriver] Improve timeout behavior. Prompted by user who executes script on busy page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/chrome/devtools_client_impl.cc ('K') | « chrome/test/chromedriver/net/sync_websocket_impl.cc ('k') | chrome/test/chromedriver/session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/session.h

diff --git a/chrome/test/chromedriver/session.h b/chrome/test/chromedriver/session.h

index fef177a75fb30dee580b864834ff249f3b830115..6a0f50e4e8fb53197da3521d0a389964521a964f 100644

--- a/chrome/test/chromedriver/session.h

+++ b/chrome/test/chromedriver/session.h

@@ -36,7 +36,7 @@ struct FrameInfo {

};

struct Session {

- static const int kDefaultPageLoadTimeoutMs;

+ static const base::TimeDelta kDefaultPageLoadTimeout;

explicit Session(const std::string& id);

Session(const std::string& id, scoped_ptr<Chrome> chrome);