Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: chrome/test/chromedriver/chrome/devtools_client_impl.h

Issue 23542005: [chromedriver] Improve timeout behavior. Prompted by user who executes script on busy page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/devtools_client_impl.h
diff --git a/chrome/test/chromedriver/chrome/devtools_client_impl.h b/chrome/test/chromedriver/chrome/devtools_client_impl.h
index 4dad6a56bfcc73cff40f8bd6fdb87519f40d960b..1fe1f0a870f0761436841cb9d7a0303d0e7901bf 100644
--- a/chrome/test/chromedriver/chrome/devtools_client_impl.h
+++ b/chrome/test/chromedriver/chrome/devtools_client_impl.h
@@ -118,7 +118,7 @@ class DevToolsClientImpl : public DevToolsClient {
const std::string& method,
const base::DictionaryValue& params,
scoped_ptr<base::DictionaryValue>* result);
- Status ProcessNextMessage(int expected_id);
+ Status ProcessNextMessage(int expected_id, const base::TimeDelta& timeout);
Status ProcessEvent(const internal::InspectorEvent& event);
Status ProcessCommandResponse(
const internal::InspectorCommandResponse& response);

Powered by Google App Engine
This is Rietveld 408576698