Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2354183002: Make Chooser tests @LargeTests (Closed)

Created:
4 years, 3 months ago by ortuno
Modified:
4 years, 2 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Chooser tests @LargeTests Because Chooser tests interact with the UI they should be marked as @LargeTests > As a rule of thumb most functional UI tests are large tests. https://developer.android.com/reference/android/support/test/filters/LargeTest.html Also remove the flaky and disabled annotations. BUG=646097, 629579 Committed: https://crrev.com/bd212bd687f343522844618f8c11edb8b449b69b Cr-Commit-Position: refs/heads/master@{#420622}

Patch Set 1 #

Patch Set 2 : Re enable test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -20 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/BluetoothChooserDialogTest.java View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java View 1 7 chunks +7 lines, -12 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/UsbChooserDialogTest.java View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
ortuno
nyquist: PTAL
4 years, 3 months ago (2016-09-21 23:14:45 UTC) #7
nyquist
lgtm
4 years, 2 months ago (2016-09-23 15:48:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354183002/20001
4 years, 2 months ago (2016-09-23 15:50:03 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-23 16:29:22 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-23 16:32:50 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd212bd687f343522844618f8c11edb8b449b69b
Cr-Commit-Position: refs/heads/master@{#420622}

Powered by Google App Engine
This is Rietveld 408576698