Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 2354163002: [tracing] Remove event callback mode in TraceLog (Closed)

Created:
4 years, 3 months ago by ssid
Modified:
4 years, 2 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tracing] Remove event callback mode in TraceLog This is not used by any component, so cleaning up TraceLog. BUG=625170 Committed: https://crrev.com/6ae272f6720806e97b1d3bfcb271e1c399dc15de Cr-Commit-Position: refs/heads/master@{#425192}

Patch Set 1 #

Patch Set 2 : rebase. #

Total comments: 2

Patch Set 3 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -306 lines) Patch
M base/trace_event/trace_event.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M base/trace_event/trace_event_unittest.cc View 1 2 1 chunk +0 lines, -227 lines 0 comments Download
M base/trace_event/trace_log.h View 1 2 5 chunks +6 lines, -33 lines 0 comments Download
M base/trace_event/trace_log.cc View 1 2 6 chunks +0 lines, -45 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (13 generated)
ssid
ptal thanks
4 years, 3 months ago (2016-09-22 00:38:37 UTC) #4
fmeawad
drive by comment https://codereview.chromium.org/2354163002/diff/20001/base/trace_event/trace_log.h File base/trace_event/trace_log.h (right): https://codereview.chromium.org/2354163002/diff/20001/base/trace_event/trace_log.h#newcode58 base/trace_event/trace_log.h:58: // Category group enabled to export ...
4 years, 3 months ago (2016-09-22 00:40:26 UTC) #8
oystein (OOO til 10th of July)
Woop woop! code-- always makes my day. lgtm ~ fadi's comment.
4 years, 3 months ago (2016-09-22 19:22:24 UTC) #9
ssid
Thanks https://codereview.chromium.org/2354163002/diff/20001/base/trace_event/trace_log.h File base/trace_event/trace_log.h (right): https://codereview.chromium.org/2354163002/diff/20001/base/trace_event/trace_log.h#newcode58 base/trace_event/trace_log.h:58: // Category group enabled to export events to ...
4 years, 2 months ago (2016-10-13 20:57:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354163002/40001
4 years, 2 months ago (2016-10-13 22:22:52 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-13 22:28:31 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 22:32:10 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6ae272f6720806e97b1d3bfcb271e1c399dc15de
Cr-Commit-Position: refs/heads/master@{#425192}

Powered by Google App Engine
This is Rietveld 408576698