New divide algorithm for Int64, final fields

pkg/fixnum/test/int_64_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library int64test;
 import 'package:fixnum/fixnum.dart';
 import 'package:unittest/unittest.dart';
 
 void main() {
   group("arithmetic operators", () {
@@ skipping 27 matching lines @@
 
     test("*", () {
       expect(new Int64.fromInt(1111) * new Int64.fromInt(3),
           new Int64.fromInt(3333));
       expect(new Int64.fromInt(1111) * new Int64.fromInt(-3),
           new Int64.fromInt(-3333));
       expect(new Int64.fromInt(-1111) * new Int64.fromInt(3),
           new Int64.fromInt(-3333));
       expect(new Int64.fromInt(-1111) * new Int64.fromInt(-3),
           new Int64.fromInt(3333));
-      expect(new Int64.fromInt(100) * new Int64.fromInt(0),
-          new Int64.fromInt(0));
+      expect(new Int64.fromInt(100) * Int64.ZERO,
+          Int64.ZERO);
 
       expect(new Int64.fromInts(0x12345678, 0x12345678) *
           new Int64.fromInts(0x1234, 0x12345678),
           new Int64.fromInts(0x7ff63f7c, 0x1df4d840));
       expect(new Int64.fromInts(0xf2345678, 0x12345678) *
           new Int64.fromInts(0x1234, 0x12345678),
           new Int64.fromInts(0x7ff63f7c, 0x1df4d840));
       expect(new Int64.fromInts(0xf2345678, 0x12345678) *
           new Int64.fromInts(0xffff1234, 0x12345678),
           new Int64.fromInts(0x297e3f7c, 0x1df4d840));
 
       // RHS Int32
       expect((new Int64.fromInt(123456789) * new Int32.fromInt(987654321)),
           new Int64.fromInts(0x1b13114, 0xfbff5385));
       expect((new Int64.fromInt(123456789) * new Int32.fromInt(987654321)),
           new Int64.fromInts(0x1b13114, 0xfbff5385));
 
       // Wraparound
       expect((new Int64.fromInt(123456789) * new Int64.fromInt(987654321)),
           new Int64.fromInts(0x1b13114, 0xfbff5385));
 
-      expect(Int64.MIN_VALUE * new Int64.fromInt(2), new Int64.fromInt(0));
+      expect(Int64.MIN_VALUE * new Int64.fromInt(2), Int64.ZERO);
       expect(Int64.MIN_VALUE * new Int64.fromInt(1), Int64.MIN_VALUE);
       expect(Int64.MIN_VALUE * new Int64.fromInt(-1), Int64.MIN_VALUE);
     });
 
     test("~/", () {
       Int64 deadBeef = new Int64.fromInts(0xDEADBEEF, 0xDEADBEEF);
       Int64 ten = new Int64.fromInt(10);
 
       expect(deadBeef ~/ ten, new Int64.fromInts(0xfcaaf97e, 0x63115fe5));
       expect(Int64.ONE ~/ Int64.TWO, Int64.ZERO);
@@ skipping 44 matching lines @@
           new Int64.fromInt(1));
       expect(new Int64.fromInt(1000) ~/ new Int64.fromInt(3),
           new Int64.fromInt(333));
       expect(new Int64.fromInt(1000) ~/ new Int64.fromInt(-3),
           new Int64.fromInt(-333));
       expect(new Int64.fromInt(-1000) ~/ new Int64.fromInt(3),
           new Int64.fromInt(-333));
       expect(new Int64.fromInt(-1000) ~/ new Int64.fromInt(-3),
           new Int64.fromInt(333));
       expect(new Int64.fromInt(3) ~/ new Int64.fromInt(1000),
-          new Int64.fromInt(0));
+          Int64.ZERO);
       expect(new Int64.fromInts( 0x12345678, 0x12345678) ~/
           new Int64.fromInts(0x0, 0x123),
           new Int64.fromInts(0x1003d0, 0xe84f5ae8));
       expect(new Int64.fromInts(0x12345678, 0x12345678) ~/
           new Int64.fromInts(0x1234, 0x12345678),
           new Int64.fromInts(0x0, 0x10003));
       expect(new Int64.fromInts(0xf2345678, 0x12345678) ~/
           new Int64.fromInts(0x1234, 0x12345678),
           new Int64.fromInts(0xffffffff, 0xffff3dfe));
       expect(new Int64.fromInts(0xf2345678, 0x12345678) ~/
           new Int64.fromInts(0xffff1234, 0x12345678),
           new Int64.fromInts(0x0, 0xeda));
       expect(new Int64.fromInt(829893893) ~/ new Int32.fromInt(1919),
           new Int32.fromInt(432461));
       expect(new Int64.fromInt(829893893) ~/ new Int64.fromInt(1919),
           new Int32.fromInt(432461));
       expect(new Int64.fromInt(829893893) ~/ 1919,
           new Int32.fromInt(432461));
-      expect(() => new Int64.fromInt(1) ~/ new Int64.fromInt(0),
+      expect(() => new Int64.fromInt(1) ~/ Int64.ZERO,
           throwsA(new isInstanceOf<IntegerDivisionByZeroException>()));
       expect(Int64.MIN_VALUE ~/ new Int64.fromInt(2),
           new Int64.fromInts(0xc0000000, 0x00000000));
       expect(Int64.MIN_VALUE ~/ new Int64.fromInt(1), Int64.MIN_VALUE);
       expect(Int64.MIN_VALUE ~/ new Int64.fromInt(-1), Int64.MIN_VALUE);
       expect(() => new Int64.fromInt(17) ~/ Int64.ZERO, throws);
       expect(() => new Int64.fromInt(17) ~/ null, throwsArgumentError);
     });
 
     test("%", () {
       // Define % as Euclidean mod, with positive result for all arguments
-      expect(Int64.ZERO % new Int64.fromInt(1000), new Int64.fromInt(0));
-      expect(Int64.MIN_VALUE % Int64.MIN_VALUE, new Int64.fromInt(0));
+      expect(Int64.ZERO % new Int64.fromInt(1000), Int64.ZERO);
+      expect(Int64.MIN_VALUE % Int64.MIN_VALUE, Int64.ZERO);
       expect(new Int64.fromInt(1000) % Int64.MIN_VALUE,
           new Int64.fromInt(1000));
-      expect(Int64.MIN_VALUE % new Int64.fromInt(8192), new Int64.fromInt(0));
+      expect(Int64.MIN_VALUE % new Int64.fromInt(8192), Int64.ZERO);
       expect(Int64.MIN_VALUE % new Int64.fromInt(8193),
           new Int64.fromInt(6145));
       expect(new Int64.fromInt(-1000) % new Int64.fromInt(8192),
           new Int64.fromInt(7192));
       expect(new Int64.fromInt(-1000) % new Int64.fromInt(8193),
           new Int64.fromInt(7193));
       expect(new Int64.fromInt(-1000000000) % new Int64.fromInt(8192),
           new Int64.fromInt(5632));
       expect(new Int64.fromInt(-1000000000) % new Int64.fromInt(8193),
           new Int64.fromInt(4808));
@@ skipping 34 matching lines @@
     Int64 largePosPlusOne = largePos + new Int64.fromInt(1);
 
     test("<", () {
       expect(new Int64.fromInt(10) < new Int64.fromInt(11), true);
       expect(new Int64.fromInt(10) < new Int64.fromInt(10), false);
       expect(new Int64.fromInt(10) < new Int64.fromInt(9), false);
       expect(new Int64.fromInt(10) < new Int32.fromInt(11), true);
       expect(new Int64.fromInt(10) < new Int32.fromInt(10), false);
       expect(new Int64.fromInt(10) < new Int32.fromInt(9), false);
       expect(new Int64.fromInt(-10) < new Int64.fromInt(-11), false);
-      expect(Int64.MIN_VALUE < new Int64.fromInt(0), true);
+      expect(Int64.MIN_VALUE < Int64.ZERO, true);
       expect(largeNeg < largePos, true);
       expect(largePos < largePosPlusOne, true);
       expect(largePos < largePos, false);
       expect(largePosPlusOne < largePos, false);
       expect(Int64.MIN_VALUE < Int64.MAX_VALUE, true);
       expect(Int64.MAX_VALUE < Int64.MIN_VALUE, false);
       expect(() => new Int64.fromInt(17) < null, throwsArgumentError);
     });
 
     test("<=", () {
@@ skipping 59 matching lines @@
       expect(new Int64.fromInt(10) > new Int32.fromInt(10), false);
       expect(new Int64.fromInt(10) > new Int32.fromInt(9), true);
       expect(new Int64.fromInt(-10) > new Int64.fromInt(-11), true);
       expect(new Int64.fromInt(10) > new Int64.fromInt(-11), true);
       expect(new Int64.fromInt(-10) > new Int64.fromInt(11), false);
       expect(largePos > largeNeg, true);
       expect(largeNeg > largePos, false);
       expect(largePos > largePosPlusOne, false);
       expect(largePos > largePos, false);
       expect(largePosPlusOne > largePos, true);
-      expect(new Int64.fromInt(0) > Int64.MIN_VALUE, true);
+      expect(Int64.ZERO > Int64.MIN_VALUE, true);
       expect(Int64.MIN_VALUE > Int64.MAX_VALUE, false);
       expect(Int64.MAX_VALUE > Int64.MIN_VALUE, true);
       expect(() => new Int64.fromInt(17) > null, throwsArgumentError);
     });
   });
 
   group("bitwise operators", () {
     Int64 n1 = new Int64.fromInt(1234);
     Int64 n2 = new Int64.fromInt(9876);
     Int64 n3 = new Int64.fromInt(-1234);
@@ skipping 315 matching lines @@
       expect(Int64.MAX_VALUE.toRadixString(10), "9223372036854775807");
       expect(Int64.MAX_VALUE.toRadixString(11), "1728002635214590697");
       expect(Int64.MAX_VALUE.toRadixString(12), "41a792678515120367");
       expect(Int64.MAX_VALUE.toRadixString(13), "10b269549075433c37");
       expect(Int64.MAX_VALUE.toRadixString(14), "4340724c6c71dc7a7");
       expect(Int64.MAX_VALUE.toRadixString(15), "160e2ad3246366807");
       expect(Int64.MAX_VALUE.toRadixString(16), "7fffffffffffffff");
     });
   });
 }