Issue 23541006: Handlify JSReceiver::SetElement method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23541006: Handlify JSReceiver::SetElement method. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger

Modified:
7 years, 3 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handlify JSReceiver::SetElement method. R=rossberg@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16448

Patch Set 2 : Addressed comments by Andreas Rossberg. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -41 lines)			Patch
	M	src/objects.h	View	1	4 chunks	+13 lines, -15 lines	0 comments	Download
	M	src/objects.cc	View	1	4 chunks	+28 lines, -26 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

Since you want to keep this dead method, you get to review it's handlification. :)

7 years, 3 months ago (2013-08-29 19:45:03 UTC) #1

rossberg

lgtm https://codereview.chromium.org/23541006/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/23541006/diff/1/src/objects.cc#newcode455 src/objects.cc:455: Handle<Object> JSProxy::SetElementWithHandler(Handle<JSProxy> object, Nit: can we name this ...

7 years, 3 months ago (2013-08-30 06:51:13 UTC) #2

Michael Starzinger

Comments addressed. Landing. https://codereview.chromium.org/23541006/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/23541006/diff/1/src/objects.cc#newcode455 src/objects.cc:455: Handle<Object> JSProxy::SetElementWithHandler(Handle<JSProxy> object, On 2013/08/30 06:51:13, ...

7 years, 3 months ago (2013-08-30 10:42:09 UTC) #3

Michael Starzinger

7 years, 3 months ago (2013-08-30 11:44:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r16448 (presubmit successful).

Expand Messages | Collapse Messages

Issue 23541006: Handlify JSReceiver::SetElement method. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comments by Andreas Rossberg. #

Messages