media: Change MediaKeyMessageEventInit to require both attributes

media: Change MediaKeyMessageEventInit to require both attributes

The latest EME spec has changed the attibutes of MediaKeyMessageEventInit
to required, so update the IDL to match. Also adds a test to verify
that both attributes are required, and that the valid values of
|messageType|.

BUG=647693
TEST=added test passes

Committed: https://crrev.com/54111faa68f577f79cb314fce7c0c658056b0e68
Cr-Commit-Position: refs/heads/master@{#420507}

[jrummell, 2016-09-21 00:01:22]

jrummell@chromium.org changed reviewers:
+ foolip@chromium.org, xhwang@chromium.org

[jrummell, 2016-09-21 00:01:23]

PTAL.

[foolip, 2016-09-21 08:32:07]

lgtm % nits

https://codereview.chromium.org/2354083003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-syntax.html
(right):

https://codereview.chromium.org/2354083003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-syntax.html:1007:
assert_equals(message_type, event.messageType);
testharness.js uses the order actual, expected, so event.messageType first

https://codereview.chromium.org/2354083003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-syntax.html:1019:
// Invalid MediaKeyMessageType values should throw a TypeError.
assert_throws(new TypeError, function() {
  new MediaKeyMessageEvent('eventType', { messageType: 'something-else',
message: new ArrayBuffer(0) });
});

https://codereview.chromium.org/2354083003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-syntax.html:1027:
// Missing required values should throw a TypeError.
assert_throws for these too.

https://codereview.chromium.org/2354083003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-syntax.html:1041:
test.done();
This can be a sync test if you drop this and just use test() above.

[xhwang, 2016-09-21 23:33:22]

lgtm % foolip's comments

[jrummell, 2016-09-22 20:12:24]

Thanks for the reviews.

https://codereview.chromium.org/2354083003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-syntax.html
(right):

https://codereview.chromium.org/2354083003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-syntax.html:1007:
assert_equals(message_type, event.messageType);
On 2016/09/21 08:32:07, foolip wrote:
> testharness.js uses the order actual, expected, so event.messageType first

Done.

https://codereview.chromium.org/2354083003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-syntax.html:1019:
// Invalid MediaKeyMessageType values should throw a TypeError.
On 2016/09/21 08:32:07, foolip wrote:
> assert_throws(new TypeError, function() {
>   new MediaKeyMessageEvent('eventType', { messageType: 'something-else',
> message: new ArrayBuffer(0) });
> });

Done.

https://codereview.chromium.org/2354083003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-syntax.html:1027:
// Missing required values should throw a TypeError.
On 2016/09/21 08:32:07, foolip wrote:
> assert_throws for these too.

Done.

https://codereview.chromium.org/2354083003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-syntax.html:1041:
test.done();
On 2016/09/21 08:32:07, foolip wrote:
> This can be a sync test if you drop this and just use test() above.

Done. Was just copying the pattern used for the other tests.

[jrummell, 2016-09-22 20:12:29]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2016-09-22 20:12:29]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org,
foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2354083003/#ps20001
(title: "test changes")

[commit-bot: I haz the power, 2016-09-22 20:12:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 21:27:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 21:27:15]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[jrummell, 2016-09-22 22:19:44]

The CQ bit was checked by jrummell@chromium.org

[jrummell, 2016-09-22 22:19:44]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org,
foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2354083003/#ps40001
(title: "update media-key-message-event-constructor test")

[commit-bot: I haz the power, 2016-09-22 22:20:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 23:51:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-22 23:53:35]

Description was changed from

==========
media: Change MediaKeyMessageEventInit to require both attributes

The latest EME spec has changed the attibutes of MediaKeyMessageEventInit
to required, so update the IDL to match. Also adds a test to verify
that both attributes are required, and that the valid values of
|messageType|.

BUG=647693
TEST=added test passes
==========

to

==========
media: Change MediaKeyMessageEventInit to require both attributes

The latest EME spec has changed the attibutes of MediaKeyMessageEventInit
to required, so update the IDL to match. Also adds a test to verify
that both attributes are required, and that the valid values of
|messageType|.

BUG=647693
TEST=added test passes

Committed: https://crrev.com/54111faa68f577f79cb314fce7c0c658056b0e68
Cr-Commit-Position: refs/heads/master@{#420507}
==========

[commit-bot: I haz the power, 2016-09-22 23:53:35]

Patchset 3 (id:??) landed as
https://crrev.com/54111faa68f577f79cb314fce7c0c658056b0e68
Cr-Commit-Position: refs/heads/master@{#420507}