Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2354073002:
Change gradle project names to use > rather than $ as separators (Closed)
DescriptionChange gradle project names to use > rather than $ as separators
The $ was sometimes causing Android Studio to show warnings that the
names were interpreted as variables. / and : are not allowed at all.
BUG=620034
TBR=jbudorick
Committed: https://crrev.com/41ced7c64711c5332daa33ec8ba95e2ff44c6599
Cr-Commit-Position: refs/heads/master@{#420222}
Patch Set 1 #
Messages
Total messages: 19 (14 generated)
Description was changed from ========== Change gradle project names to use > rather than $ as separators The $ was sometimes causing Android Studio to show warnings that the names were interpreted as variables. BUG=620034 ========== to ========== Change gradle project names to use > rather than $ as separators The $ was sometimes causing Android Studio to show warnings that the names were interpreted as variables. BUG=620034 ==========
agrieve@chromium.org changed reviewers: + wnwen@chromium.org
agrieve@chromium.org changed reviewers: + jbudorick@chromium.org - wnwen@chromium.org
On 2016/09/20 20:37:29, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org > - mailto:wnwen@chromium.org
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Change gradle project names to use > rather than $ as separators The $ was sometimes causing Android Studio to show warnings that the names were interpreted as variables. BUG=620034 ========== to ========== Change gradle project names to use > rather than $ as separators The $ was sometimes causing Android Studio to show warnings that the names were interpreted as variables. / and : are not allowed at all. BUG=620034 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Change gradle project names to use > rather than $ as separators The $ was sometimes causing Android Studio to show warnings that the names were interpreted as variables. / and : are not allowed at all. BUG=620034 ========== to ========== Change gradle project names to use > rather than $ as separators The $ was sometimes causing Android Studio to show warnings that the names were interpreted as variables. / and : are not allowed at all. BUG=620034 TBR=jbudorick ==========
The CQ bit was checked by agrieve@chromium.org
The CQ bit was unchecked by agrieve@chromium.org
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Change gradle project names to use > rather than $ as separators The $ was sometimes causing Android Studio to show warnings that the names were interpreted as variables. / and : are not allowed at all. BUG=620034 TBR=jbudorick ========== to ========== Change gradle project names to use > rather than $ as separators The $ was sometimes causing Android Studio to show warnings that the names were interpreted as variables. / and : are not allowed at all. BUG=620034 TBR=jbudorick ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Change gradle project names to use > rather than $ as separators The $ was sometimes causing Android Studio to show warnings that the names were interpreted as variables. / and : are not allowed at all. BUG=620034 TBR=jbudorick ========== to ========== Change gradle project names to use > rather than $ as separators The $ was sometimes causing Android Studio to show warnings that the names were interpreted as variables. / and : are not allowed at all. BUG=620034 TBR=jbudorick Committed: https://crrev.com/41ced7c64711c5332daa33ec8ba95e2ff44c6599 Cr-Commit-Position: refs/heads/master@{#420222} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/41ced7c64711c5332daa33ec8ba95e2ff44c6599 Cr-Commit-Position: refs/heads/master@{#420222}
Message was sent while issue was closed.
Missed a bunch of these in my inbox somehow. :( lgtm |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
