Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2354053002: Delete MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon. (Closed)

Created:
4 years, 3 months ago by fdoray
Modified:
4 years, 3 months ago
Reviewers:
dcheng
CC:
chromium-reviews, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon. These methods are deprecated and are no longer used in Chrome. To post a task to a MessageLoop, developers should use its TaskRunner: s/MessageLoop::current()->PostTask/ThreadTaskRunnerHandle::Get()->PostTask/ s/MessageLoop::current()->PostDelayedTask/ThreadTaskRunnerHandle::Get()->PostDelayedTask/ s/MessageLoop::current()->DeleteSoon/ThreadTaskRunnerHandle::Get()->DeleteSoon/ s/MessageLoop::current()->ReleaseSoon/ThreadTaskRunnerHandle::Get()->ReleaseSoon/ s/message_loop->PostTask/message_loop->task_runner()->PostTask/ s/message_loop->PostDelayedTask/message_loop->task_runner()->PostDelayedTask/ s/message_loop->DeleteSoon/message_loop->task_runner()->DeleteSoon/ s/message_loop->ReleaseSoon/message_loop->task_runner()->ReleaseSoon/ BUG=616447 Committed: https://crrev.com/f8f41410b8ae7ace0ed51191668451ab40689233 Cr-Commit-Position: refs/heads/master@{#420071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -124 lines) Patch
M base/message_loop/message_loop.h View 5 chunks +2 lines, -90 lines 0 comments Download
M base/message_loop/message_loop.cc View 4 chunks +0 lines, -34 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
fdoray
PTAL
4 years, 3 months ago (2016-09-20 20:37:20 UTC) #6
dcheng
LGTM, but please update the CL description to document the replacements.
4 years, 3 months ago (2016-09-20 22:35:22 UTC) #7
fdoray
On 2016/09/20 22:35:22, dcheng wrote: > LGTM, but please update the CL description to document ...
4 years, 3 months ago (2016-09-21 12:09:37 UTC) #9
fdoray
Passed ios_internal smoke tests.
4 years, 3 months ago (2016-09-21 12:56:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354053002/1
4 years, 3 months ago (2016-09-21 12:57:18 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 15:46:19 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 15:48:01 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8f41410b8ae7ace0ed51191668451ab40689233
Cr-Commit-Position: refs/heads/master@{#420071}

Powered by Google App Engine
This is Rietveld 408576698