Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2354003002: Build rule for pdf_codec_fax_fuzzer (Closed)

Created:
4 years, 3 months ago by kcwu
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, fuzzing_chromium.org, Tom Sepez
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build rule for pdf_codec_fax_fuzzer Committed: https://crrev.com/a6dc4f682f6db2b4792963ef5a26929d8a728f2a Cr-Commit-Position: refs/heads/master@{#419859}

Patch Set 1 #

Total comments: 2

Patch Set 2 : move order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M pdf/pdfium/fuzzers/BUILD.gn View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
kcwu
4 years, 3 months ago (2016-09-20 17:42:12 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/2354003002/diff/1/pdf/pdfium/fuzzers/BUILD.gn File pdf/pdfium/fuzzers/BUILD.gn (right): https://codereview.chromium.org/2354003002/diff/1/pdf/pdfium/fuzzers/BUILD.gn#newcode14 pdf/pdfium/fuzzers/BUILD.gn:14: fuzzer_test("pdf_codec_fax_fuzzer") { Can you move this down to ...
4 years, 3 months ago (2016-09-20 17:53:47 UTC) #3
kcwu
https://codereview.chromium.org/2354003002/diff/1/pdf/pdfium/fuzzers/BUILD.gn File pdf/pdfium/fuzzers/BUILD.gn (right): https://codereview.chromium.org/2354003002/diff/1/pdf/pdfium/fuzzers/BUILD.gn#newcode14 pdf/pdfium/fuzzers/BUILD.gn:14: fuzzer_test("pdf_codec_fax_fuzzer") { On 2016/09/20 17:53:46, Lei Zhang wrote: > ...
4 years, 3 months ago (2016-09-20 18:00:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354003002/20001
4 years, 3 months ago (2016-09-20 18:01:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/282887)
4 years, 3 months ago (2016-09-20 20:18:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2354003002/20001
4 years, 3 months ago (2016-09-20 20:32:17 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 21:43:44 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 21:45:07 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a6dc4f682f6db2b4792963ef5a26929d8a728f2a
Cr-Commit-Position: refs/heads/master@{#419859}

Powered by Google App Engine
This is Rietveld 408576698