We do and test only AST based summaries.

We do and test only AST based summaries.

There are 3 tests failing.

According to the Spec 'void' and 'dynamic' cannot be prefixes.
"It is a compile-time error if a built-in identifier is used as the declared name of a prefix, class, type parameter or type alias."
So, most probably these tests should be changed to test that the prefix is null.

I will look into "fail_invalid_prefix_type_parameter" in a separate CL.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/1401a38d59b6b1e2dc43e645cd1cbf5d61738aaf

[Paul Berry, 2016-09-20 16:56:50]

lgtm

[scheglov, 2016-09-20 17:49:02]

Description was changed from

==========
We do and test only AST based summaries.

There are 3 tests failing.

According to the Spec 'void' and 'dynamic' cannot be prefixes.
"It is a compile-time error if a built-in identifier is used as the declared
name of a prefix, class, type parameter or type alias."
So, most probably these tests should be changed to test that the prefix is null.

I will look into "fail_invalid_prefix_type_parameter" in a separate CL.

R=paulberry@google.com
BUG=
==========

to

==========
We do and test only AST based summaries.

There are 3 tests failing.

According to the Spec 'void' and 'dynamic' cannot be prefixes.
"It is a compile-time error if a built-in identifier is used as the declared
name of a prefix, class, type parameter or type alias."
So, most probably these tests should be changed to test that the prefix is null.

I will look into "fail_invalid_prefix_type_parameter" in a separate CL.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/1401a38d59b6b1e2dc43e645cd1cbf5d61738aaf
==========

[scheglov, 2016-09-20 17:49:04]

Committed patchset #1 (id:1) manually as
1401a38d59b6b1e2dc43e645cd1cbf5d61738aaf (presubmit successful).