Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 2353963003: Delete unused in CPDF_CMapManager, CPDF_CMapParser (Closed)

Created:
4 years, 3 months ago by npm
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, dsinclair, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Delete unused methods and variables in CPDF_CMapManager and in CPDF_CMapParser Committed: https://pdfium.googlesource.com/pdfium/+/785c8d348207937942924d4371aaa137d9ec07de

Patch Set 1 #

Patch Set 2 : Deletions in CPDF_CMapParser #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M core/fpdfapi/fpdf_font/font_int.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
npm
PTAL
4 years, 3 months ago (2016-09-20 20:35:56 UTC) #8
Lei Zhang
lgtm
4 years, 3 months ago (2016-09-20 20:36:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353963003/20001
4 years, 3 months ago (2016-09-20 20:48:07 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 20:48:21 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/785c8d348207937942924d4371aaa137d9ec...

Powered by Google App Engine
This is Rietveld 408576698