Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2353943002: Fix compilation failure with GCC 5 (Closed)

Created:
4 years, 3 months ago by ivica.bogosavljevic
Modified:
4 years, 3 months ago
Reviewers:
vogelheim, marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix compilation failure with GCC 5 BUG= Committed: https://crrev.com/ade29503dd4af08f9eb8a3e51b5c79f7d0699086 Cr-Commit-Position: refs/heads/master@{#39576}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M test/cctest/parsing/test-scanner.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
ivica.bogosavljevic
PTAL
4 years, 3 months ago (2016-09-20 13:31:35 UTC) #2
vogelheim
lgtm Thanks for the fix. That was a left-over from an earlier version that I ...
4 years, 3 months ago (2016-09-20 13:41:27 UTC) #3
marja
lgtm
4 years, 3 months ago (2016-09-20 18:44:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353943002/1
4 years, 3 months ago (2016-09-21 07:16:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-21 07:18:31 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 07:18:53 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ade29503dd4af08f9eb8a3e51b5c79f7d0699086
Cr-Commit-Position: refs/heads/master@{#39576}

Powered by Google App Engine
This is Rietveld 408576698