Fix Mirror header on Drive domains.

Fix Mirror header on Drive domains.

Ensure the GAIA Id is attached for Drive domains even when the path
isn't empty.
Follow-up of http://crrev.com/2343073002.

BUG=647260
Committed: https://crrev.com/1abe938f538848537ead6a74f079ad58fac5f52b
Cr-Commit-Position: refs/heads/master@{#420605}

[bzanotti, 2016-09-20 14:49:46]

bzanotti@chromium.org changed reviewers:
+ rogerta@chromium.org

[bzanotti, 2016-09-20 14:49:47]

Please take a look.

[Roger Tawa OOO till Jul 10th, 2016-09-20 15:07:56]

Looks good Benoit.  Add some tests like Dominic suggested?

https://codereview.chromium.org/2353923003/diff/1/components/signin/core/brow...
File components/signin/core/browser/signin_header_helper.cc (right):

https://codereview.chromium.org/2353923003/diff/1/components/signin/core/brow...
components/signin/core/browser/signin_header_helper.cc:63: return domain ==
"google.com";
Nit: instead of hardcoding the string, should we instead say something like:

  return GURL(domain) ==
      GaiaUrls::GetInstance()->google_url().GetOrigin();

[bzanotti, 2016-09-21 13:41:11]

Patchset #2 (id:20001) has been deleted

[bzanotti, 2016-09-21 13:44:44]

Sorry, I was sure I had explained but apparently not.

I'm working on a second CL to add some unittests but I'm not finished yet (still
figuring out how to test the header function properly). I'd like to submit this
one first in order to fix the bug.

https://codereview.chromium.org/2353923003/diff/1/components/signin/core/brow...
File components/signin/core/browser/signin_header_helper.cc (right):

https://codereview.chromium.org/2353923003/diff/1/components/signin/core/brow...
components/signin/core/browser/signin_header_helper.cc:63: return domain ==
"google.com";
On 2016/09/20 15:07:56, Roger Tawa wrote:
> Nit: instead of hardcoding the string, should we instead say something like:
> 
>   return GURL(domain) ==
>       GaiaUrls::GetInstance()->google_url().GetOrigin();

The domain is not the same thing as the origin, I don't like the idea of
comparing the two. I'd have to do either:

GURL("http://" + domain) == GaiaUrls::GetInstance()->google_url().GetOrigin()

or

domain ==
net::registry_controlled_domains::GetDomainAndRegistry(GaiaUrls::GetInstance()->google_url(),
net::registry_controlled_domains::EXCLUDE_PRIVATE_REGISTRIES)

I don't really like either solution, so I kept the current one.

[Roger Tawa OOO till Jul 10th, 2016-09-22 14:14:23]

lgtm

[bzanotti, 2016-09-22 17:11:22]

The CQ bit was checked by bzanotti@chromium.org

[commit-bot: I haz the power, 2016-09-22 17:11:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 18:08:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 18:08:25]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[bzanotti, 2016-09-23 09:08:18]

The CQ bit was checked by bzanotti@chromium.org

[commit-bot: I haz the power, 2016-09-23 09:08:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 09:33:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 09:33:54]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[bzanotti, 2016-09-23 09:37:09]

The CQ bit was checked by bzanotti@chromium.org

[commit-bot: I haz the power, 2016-09-23 09:37:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 11:42:03]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-23 11:43:33]

Description was changed from

==========
Fix Mirror header on Drive domains.

Ensure the GAIA Id is attached for Drive domains even when the path
isn't empty.
Follow-up of http://crrev.com/2343073002.

BUG=647260
==========

to

==========
Fix Mirror header on Drive domains.

Ensure the GAIA Id is attached for Drive domains even when the path
isn't empty.
Follow-up of http://crrev.com/2343073002.

BUG=647260

Committed: https://crrev.com/1abe938f538848537ead6a74f079ad58fac5f52b
Cr-Commit-Position: refs/heads/master@{#420605}
==========

[commit-bot: I haz the power, 2016-09-23 11:43:34]

Patchset 2 (id:??) landed as
https://crrev.com/1abe938f538848537ead6a74f079ad58fac5f52b
Cr-Commit-Position: refs/heads/master@{#420605}