Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2353903002: {CSS,XSL}StyleSheetResource should mark their clients as finished on checkNotify (Closed)

Created:
4 years, 3 months ago by kouhei (in TOK)
Modified:
4 years, 3 months ago
Reviewers:
hiroshige, yhirano
CC:
chromium-reviews, tyoshino+watch_chromium.org, blink-reviews-style_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

{CSS,XSL}StyleSheetResource should mark their clients as finished on checkNotify Before this CL, {CSS,XSL}StyleSheetResource::checkNotify didn't trigger markClientFinished as Resource::checkNotify did. This CL aligns {CSS,XSL}StyleSheetResource::checkNotify to trigger it properly. BUG=647151 Committed: https://crrev.com/3598c8bc9c56409f7c239c377fe6e42786d6aaa0 Cr-Commit-Position: refs/heads/master@{#419969}

Patch Set 1 #

Patch Set 2 : add expectedtxt #

Total comments: 4

Patch Set 3 : yhirano style #

Messages

Total messages: 19 (12 generated)
kouhei (in TOK)
4 years, 3 months ago (2016-09-20 08:22:05 UTC) #2
yhirano
lgtm, thanks. https://codereview.chromium.org/2353903002/diff/20001/third_party/WebKit/LayoutTests/http/tests/loading/css-no-cache-revalidation.html File third_party/WebKit/LayoutTests/http/tests/loading/css-no-cache-revalidation.html (right): https://codereview.chromium.org/2353903002/diff/20001/third_party/WebKit/LayoutTests/http/tests/loading/css-no-cache-revalidation.html#newcode41 third_party/WebKit/LayoutTests/http/tests/loading/css-no-cache-revalidation.html:41: return new Promise((resolve, _) => { [optional] ...
4 years, 3 months ago (2016-09-21 00:59:37 UTC) #11
kouhei (in TOK)
https://codereview.chromium.org/2353903002/diff/20001/third_party/WebKit/LayoutTests/http/tests/loading/css-no-cache-revalidation.html File third_party/WebKit/LayoutTests/http/tests/loading/css-no-cache-revalidation.html (right): https://codereview.chromium.org/2353903002/diff/20001/third_party/WebKit/LayoutTests/http/tests/loading/css-no-cache-revalidation.html#newcode41 third_party/WebKit/LayoutTests/http/tests/loading/css-no-cache-revalidation.html:41: return new Promise((resolve, _) => { On 2016/09/21 00:59:37, ...
4 years, 3 months ago (2016-09-21 01:02:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353903002/40001
4 years, 3 months ago (2016-09-21 01:03:06 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-21 03:55:03 UTC) #16
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/3598c8bc9c56409f7c239c377fe6e42786d6aaa0 Cr-Commit-Position: refs/heads/master@{#419969}
4 years, 3 months ago (2016-09-21 03:58:58 UTC) #18
hiroshige
4 years, 3 months ago (2016-09-21 04:59:49 UTC) #19
Message was sent while issue was closed.
lgtm. thanks for fixing!

Powered by Google App Engine
This is Rietveld 408576698