Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: pkg/unittest/lib/test_controller.js

Issue 23539003: Turn on Polymer TodoMVC tests on Dart buildbots (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: use unittest test_controller.js Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/unittest/lib/test_controller.js
diff --git a/pkg/unittest/lib/test_controller.js b/pkg/unittest/lib/test_controller.js
index 439b7033aea8b4d4a097ec61f907ad8848ba0cc4..fc8db1611a5ae5b792cff8cfba3b2e6357dd3ede 100644
--- a/pkg/unittest/lib/test_controller.js
+++ b/pkg/unittest/lib/test_controller.js
@@ -23,7 +23,8 @@ window.onerror = function (message, url, lineNumber) {
window.postMessage('unittest-suite-external-error', '*');
};
-if (navigator.webkitStartDart) {
+// Start Dartium/content_shell, unless we are waiting for HTML Imports to load.
+if (navigator.webkitStartDart && !window.HTMLImports) {
Siggi Cherem (dart-lang) 2013/08/28 19:46:51 mmm. I worry there might be cases where people use
Jennifer Messerly 2013/08/28 19:56:04 Chatted in person ... we should really move some o
navigator.webkitStartDart();
}

Powered by Google App Engine
This is Rietveld 408576698