Turn on Polymer TodoMVC tests on Dart buildbots

pkg/polymer/lib/testing/test_controller.js

-// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Test controller logic - used by unit test harness to embed tests in
  * conent shell.
+ *
+ * *NOTE*: this is a fork of package:unittest/test_controller.js.
+ * It has been modified to work with package:polymer/boot.js.

[kustermann, 2013/08/28 17:56:45]

This is really bad. We should not fork!
It's really error prone if we have to keep these two in sync.

What is the difference between this and the original version?
Could extend the original version to make it work for polymer as well?

[Jennifer Messerly, 2013/08/28 18:11:06]

agreed, we already have a copy in polymer/lib/testing.js though, so at least it
isn't making it worse. :)

I'm trying to get browser test coverage for Polymer again (currently it is at 0
browser tests running) hence a bit of desperation on my part to get something
working and iterate...
The difference is below. We can't call webkitStartDart in this file, it needs to
happen later when Polymer's boot.js is ready.

here's an idea: I could add a flag to unittest/lib/test_controller.js to
suppress the webkitStartDart call, and set that from polymer/lib/boot.js. Would
that work for you?

FYI here is boot.js:
https://github.com/dart-lang/bleeding_edge/blob/master/dart/pkg/polymer/lib/b...

[Siggi Cherem (dart-lang), 2013/08/28 18:21:10]

I was also thinking of the same approach =)

  */
 
 // Clear the console before every test run - this is Firebug specific code.
 if (typeof console == "object" && typeof console.clear == "function") {
   console.clear();
 }
 // Set window onerror to make sure that we catch test harness errors across all
 // browsers.
 window.onerror = function (message, url, lineNumber) {
   if (url) {
     showErrorAndExit(
         "\n\n" + url + ":" + lineNumber + ":\n" + message + "\n\n");
   } else {
     showErrorAndExit(message);
   }
   window.postMessage('unittest-suite-external-error', '*');
 };
 
-if (navigator.webkitStartDart) {
-  navigator.webkitStartDart();
-}

[kustermann, 2013/08/28 17:56:45]

Why did you remove this?

This is needed for dartium/content_shell.

[Jennifer Messerly, 2013/08/28 18:11:06]

Polymer's "boot.js" knows how to start Dartium. That's the only reason to fork
this file. test_controller.js is trying to start Dartium way too soon for
boot.js to work properly.

-
 // testRunner is provided by content shell.
 // It is not available in selenium tests.
 var testRunner = window.testRunner || window.layoutTestController;
 
 var waitForDone = false;
 
 // Returns the driving window object if available
 function getDriverWindow() {
   if (window != window.parent) {
     // We're running in an iframe.
@@ skipping 124 matching lines @@
   try {
     main();
   } catch (e) {
     dartPrint(e);
     if (e.stack) dartPrint(e.stack);
     window.postMessage('unittest-suite-fail', '*');
     return;
   }
   window.postMessage('dart-main-done', '*');
 }