Prune CreateVisiblePositionDeprecated from SelectionController

Prune CreateVisiblePositionDeprecated from SelectionController

BUG=647219
Committed: https://crrev.com/f42cd8c43eac573dab21b9599aaa095c3a4f9745
Cr-Commit-Position: refs/heads/master@{#419968}

[Xiaocheng, 2016-09-20 06:11:54]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 06:12:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-20 07:08:50]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-09-20 07:08:51]

PTAL.

At first I thought that a function with a HitTestResult parameter must be called
with clean layout, which turns out to be wrong in
SelectionController::updateSelectionForMouseDrag.

Is this still desired, and why?

[commit-bot: I haz the power, 2016-09-20 07:31:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 07:31:12]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-09-20 08:24:11]

lgtm

On 2016/09/20 at 07:08:51, xiaochengh wrote:
> PTAL.
> 
> At first I thought that a function with a HitTestResult parameter must be
called with clean layout, which turns out to be wrong in
SelectionController::updateSelectionForMouseDrag.
> 
> Is this still desired, and why?
No. HitTestResult parameter can be used in dirty tree.


The hit test must be done with clean layout tree, |LayoutView::hitTest()| calls
|frameView()->updateLifecycleToCompositingCleanPlusScrolling()|.
Once, event path is computed, it is done before calling event handlers, it is OK
to make layout tree dirty, JS event handler can modify DOM tree.

I'm pretty sure press and release handler can be called with dirty layout tree
due by JS event handler.

Also, I confirmed |SelectionController::updateSelectionForMouseDrag()| is called
after |updatePointerTargetAndDispatchEvents(()| in
|EventHandler::handleMouseMoveOrLeaveEvent()|. So,
|updateSelectionForMouseDrag()| is called with dirty layout tree.

[Xiaocheng, 2016-09-20 10:45:22]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 10:45:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-20 11:38:56]

Added layout update to handleMouseReleaseEvent and
passMousePressEventToSubframe, instead of just waiting for ClusterFuzz to catch
me.

[commit-bot: I haz the power, 2016-09-20 12:52:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 12:52:49]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-09-21 03:45:13]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-09-21 03:45:14]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2353893002/#ps20001
(title: "Update layout in handleMouseReleaseEvent and
passMousePressEventToSubframe")

[commit-bot: I haz the power, 2016-09-21 03:45:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 03:53:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-21 03:56:07]

Description was changed from

==========
Prune CreateVisiblePositionDeprecated from SelectionController

BUG=647219
==========

to

==========
Prune CreateVisiblePositionDeprecated from SelectionController

BUG=647219

Committed: https://crrev.com/f42cd8c43eac573dab21b9599aaa095c3a4f9745
Cr-Commit-Position: refs/heads/master@{#419968}
==========

[commit-bot: I haz the power, 2016-09-21 03:56:07]

Patchset 2 (id:??) landed as
https://crrev.com/f42cd8c43eac573dab21b9599aaa095c3a4f9745
Cr-Commit-Position: refs/heads/master@{#419968}