Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1418)

Issue 2353853002: ServiceWorker: Add CHECK to EmbeddedWorkerRegistry for debug (Closed)

Created:
4 years, 3 months ago by nhiroki
Modified:
4 years, 3 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Add CHECK to EmbeddedWorkerRegistry for debug BUG=648477 Committed: https://crrev.com/9ea783ee0201e243384f98dc38f101e4bed5c8ca Cr-Commit-Position: refs/heads/master@{#419681}

Patch Set 1 #

Patch Set 2 : fix compile failures #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/browser/service_worker/embedded_worker_registry.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
nhiroki
ptal
4 years, 3 months ago (2016-09-20 01:52:35 UTC) #3
falken
lgtm
4 years, 3 months ago (2016-09-20 01:55:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353853002/1
4 years, 3 months ago (2016-09-20 02:05:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/202410)
4 years, 3 months ago (2016-09-20 02:16:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353853002/20001
4 years, 3 months ago (2016-09-20 03:07:26 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 05:02:13 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9ea783ee0201e243384f98dc38f101e4bed5c8ca Cr-Commit-Position: refs/heads/master@{#419681}
4 years, 3 months ago (2016-09-20 05:04:28 UTC) #15
nhiroki
4 years, 2 months ago (2016-10-18 03:31:44 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2428753003/ by nhiroki@chromium.org.

The reason for reverting is: We've collected enough information for debug..

Powered by Google App Engine
This is Rietveld 408576698