Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2353843002: Add position sticky main thread scrolling reason [spv2] (Closed)
Patch Set: Embrace the rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
index 0bba976b0be7e1ac39ba9c2a5334b26dc1dabd67..6925636a35b3f63bea84892c405ce8e01efa9f57 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
@@ -358,6 +358,10 @@ void LayoutBoxModelObject::styleDidChange(StyleDifference diff, const ComputedSt
// the sticky position constraints then.
if (layer())
layer()->setNeedsCompositingInputsUpdate();
+
+ // TODO(pdr): When slimming paint v2 is enabled, we will need to
+ // invalidate the scroll paint property subtree for this so main
+ // thread scroll reasons are recomputed.
} else {
// This may get re-added to viewport constrained objects if the object went
// from sticky to fixed.
@@ -370,6 +374,10 @@ void LayoutBoxModelObject::styleDidChange(StyleDifference diff, const ComputedSt
if (const PaintLayer* ancestorOverflowLayer = layer()->ancestorOverflowLayer())
ancestorOverflowLayer->getScrollableArea()->invalidateStickyConstraintsFor(layer());
}
+
+ // TODO(pdr): When slimming paint v2 is enabled, we will need to
+ // invalidate the scroll paint property subtree for this so main
+ // thread scroll reasons are recomputed.
}
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698