Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2353833002: Reland bot_update: add --auth-refresh-token-json passthrough for apply_issue (Closed)

Created:
4 years, 3 months ago by Ryan Tseng
Modified:
4 years, 3 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reland bot_update: add --auth-refresh-token-json passthrough for apply_issue Reland of https://codereview.chromium.org/2294413002/ after a rebase fix. BUG=642150 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/b61b9b7583c58c878a63eec5955be7ebd0c37403

Patch Set 1 #

Patch Set 2 : Rebase fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -17 lines) Patch
M recipe_modules/bot_update/api.py View 5 chunks +13 lines, -4 lines 0 comments Download
M recipe_modules/bot_update/example.py View 4 chunks +15 lines, -0 lines 0 comments Download
A + recipe_modules/bot_update/example.expected/trychange_oauth2_json.json View 1 chunk +3 lines, -2 lines 0 comments Download
A + recipe_modules/bot_update/example.expected/trychange_oauth2_json_win.json View 2 chunks +5 lines, -4 lines 0 comments Download
M recipe_modules/bot_update/resources/bot_update.py View 1 7 chunks +17 lines, -7 lines 0 comments Download
M tests/bot_update_coverage_test.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Ryan Tseng
ptal see diff between ps1 and ps2
4 years, 3 months ago (2016-09-20 01:20:28 UTC) #6
tandrii(chromium)
LGTM % we should really update these args to kwargs.
4 years, 3 months ago (2016-09-20 02:02:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353833002/20001
4 years, 3 months ago (2016-09-21 20:18:01 UTC) #11
Ryan Tseng
I shall do that in another CL, minimizing diffs for now.
4 years, 3 months ago (2016-09-21 20:18:13 UTC) #12
tandrii(chromium)
On 2016/09/21 20:18:13, Ryan Tseng wrote: > I shall do that in another CL, minimizing ...
4 years, 3 months ago (2016-09-21 20:19:51 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-21 20:21:25 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/b61b9b7583c58c...

Powered by Google App Engine
This is Rietveld 408576698