Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2353813002: Match offline page url with fragment identifier stripped (Closed)

Created:
4 years, 3 months ago by jianli
Modified:
4 years, 2 months ago
Reviewers:
Dmitry Titov
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Match offline page url with fragment identifier stripped BUG=647872 TEST=new test added Committed: https://crrev.com/20995bec1e1cdefa14e5aee3c9c99b960045cac8 Cr-Commit-Position: refs/heads/master@{#423025}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2 lines) Patch
M components/offline_pages/offline_page_model_impl.cc View 1 chunk +16 lines, -2 lines 0 comments Download
M components/offline_pages/offline_page_model_impl_unittest.cc View 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jianli
4 years, 3 months ago (2016-09-20 00:27:43 UTC) #4
Dmitry Titov
lgtm
4 years, 3 months ago (2016-09-20 20:46:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353813002/1
4 years, 2 months ago (2016-10-04 23:48:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 00:44:14 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 00:50:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20995bec1e1cdefa14e5aee3c9c99b960045cac8
Cr-Commit-Position: refs/heads/master@{#423025}

Powered by Google App Engine
This is Rietveld 408576698