Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 2353803002: Reset underflow count upon seek event. (Closed)

Created:
4 years, 3 months ago by DaleCurtis
Modified:
4 years, 3 months ago
Reviewers:
chcunningham
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset underflow count upon seek event. This is inline with what we do for watch time and prevents looping videos from skewing underflow counts. BUG=641633 Committed: https://crrev.com/af34d871739e277c5807de7d646de6b1ef49c07a Cr-Commit-Position: refs/heads/master@{#419679}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M media/blink/webmediaplayer_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
DaleCurtis
4 years, 3 months ago (2016-09-19 23:50:41 UTC) #2
chcunningham
lgtm
4 years, 3 months ago (2016-09-20 00:12:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353803002/1
4 years, 3 months ago (2016-09-20 00:17:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/144226)
4 years, 3 months ago (2016-09-20 01:36:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353803002/1
4 years, 3 months ago (2016-09-20 03:19:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 04:32:46 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 04:35:03 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/af34d871739e277c5807de7d646de6b1ef49c07a
Cr-Commit-Position: refs/heads/master@{#419679}

Powered by Google App Engine
This is Rietveld 408576698