Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2353793003: [turbofan] Ship generators if --turbo-from-bytecode set. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Ship generators if --turbo-from-bytecode set. This makes sure generator functions are marked as optimizable for all configurations where the BytecodeGraphBuilder is used. Note that as usual AstNumbering is just a heuristic and the underlying compiler can still bailout from optimization when the compilation pipeline chooses another compiler that does not support generator functions. R=bmeurer@chromium.org,hablich@chromium.org Committed: https://crrev.com/b88df1c9e4d092b32478df9fe053263c279d0f2f Cr-Commit-Position: refs/heads/master@{#39553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/ast/ast-numbering.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Michael Starzinger
4 years, 3 months ago (2016-09-20 13:03:31 UTC) #3
Michael Hablich
On 2016/09/20 13:03:31, Michael Starzinger wrote: awesome lgtm, please add Ross too.
4 years, 3 months ago (2016-09-20 13:08:31 UTC) #4
Michael Starzinger
Michael: PTAL. Ross & Benedikt: FYI.
4 years, 3 months ago (2016-09-20 13:08:42 UTC) #6
rmcilroy
LGTM :)
4 years, 3 months ago (2016-09-20 13:12:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2353793003/1
4 years, 3 months ago (2016-09-20 13:28:07 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 13:43:07 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b88df1c9e4d092b32478df9fe053263c279d0f2f Cr-Commit-Position: refs/heads/master@{#39553}
4 years, 3 months ago (2016-09-20 13:44:22 UTC) #14
Benedikt Meurer
4 years, 3 months ago (2016-09-20 17:24:50 UTC) #15
Message was sent while issue was closed.
LGTM, thanks.

Powered by Google App Engine
This is Rietveld 408576698