Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 2353793002: kernel->ssa: implement top-level getters and setters (Closed)

Created:
4 years, 3 months ago by Harry Terkelsen
Modified:
4 years, 3 months ago
Reviewers:
Johnni Winther, sra1
CC:
reviews_dartlang.org, dart-kernel+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : extract common subexpression #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -22 lines) Patch
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 3 chunks +17 lines, -22 lines 0 comments Download
A tests/compiler/dart2js/kernel/getters_setters_test.dart View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Harry Terkelsen
4 years, 3 months ago (2016-09-19 23:35:03 UTC) #4
Johnni Winther
lgtm
4 years, 3 months ago (2016-09-20 08:15:25 UTC) #5
Harry Terkelsen
4 years, 3 months ago (2016-09-20 17:18:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
636084afa21f261fb5068a4dbbbbae355a435cee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698