Remove 'serializeLibrary(LibraryElement)' and its tests.

Remove 'serializeLibrary(LibraryElement)' and its tests.

Switch PrelinkerTest to AST based unlinked summaries.

The *_common.dart files in tests might be not actually 'common', and
we could pull them into corresponding only subclasses.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/d13a8872927a9ecd1e7df5e8dca4c258371fb3e6

[Paul Berry, 2016-09-20 02:23:59]

I might be mistaken, but I think we're losing some important test coverage here.
 Previous to this CL, our resynthesis tests were:
- ResynthesizeElementTest (element-based, spec mode)
- ResynthesizeStrongTest (element-based, strong mode)
- ResynthesizeAstTest (AST-based, spec mode)

After this CL, it looks like just ResynthesizeAstTest is left, so we aren't
testing strong mode resynthesis very thoroughly anymore.

(Note that AstInferredTypeTest still runs in strong mode, but that's not a
thorough test of strong mode resynthesis; it just checks type inference).

[scheglov, 2016-09-20 03:19:28]

On 2016/09/20 02:23:59, Paul Berry wrote:
> I might be mistaken, but I think we're losing some important test coverage
here.
>  Previous to this CL, our resynthesis tests were:
> - ResynthesizeElementTest (element-based, spec mode)
> - ResynthesizeStrongTest (element-based, strong mode)
> - ResynthesizeAstTest (AST-based, spec mode)
> 
> After this CL, it looks like just ResynthesizeAstTest is left, so we aren't
> testing strong mode resynthesis very thoroughly anymore.
> 
> (Note that AstInferredTypeTest still runs in strong mode, but that's not a
> thorough test of strong mode resynthesis; it just checks type inference).

PTAL

You're right.
I've added tests for resynthesizing using AST summaries in strong mode.
There are several failing tests, mostly because we don't support these cases.

There is or two cases where a method is not implemented in Link classes.

[Paul Berry, 2016-09-20 03:25:45]

lgtm

[scheglov, 2016-09-20 03:28:58]

Description was changed from

==========
Remove 'serializeLibrary(LibraryElement)' and its tests.

Switch PrelinkerTest to AST based unlinked summaries.

The *_common.dart files in tests might be not actually 'common', and
we could pull them into corresponding only subclasses.

R=paulberry@google.com
BUG=
==========

to

==========
Remove 'serializeLibrary(LibraryElement)' and its tests.

Switch PrelinkerTest to AST based unlinked summaries.

The *_common.dart files in tests might be not actually 'common', and
we could pull them into corresponding only subclasses.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/d13a8872927a9ecd1e7df5e8dca4c258371fb3e6
==========

[scheglov, 2016-09-20 03:29:01]

Committed patchset #3 (id:40001) manually as
d13a8872927a9ecd1e7df5e8dca4c258371fb3e6 (presubmit successful).