Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1499)

Unified Diff: net/quic/test_tools/crypto_test_utils_test.cc

Issue 2353763002: Use refcounted ownership for ValidateClientHelloResultCallback::Result (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/test_tools/crypto_test_utils_test.cc
diff --git a/net/quic/test_tools/crypto_test_utils_test.cc b/net/quic/test_tools/crypto_test_utils_test.cc
index 5e27e668e0b8becd6640c6732f2069cb549dc449..e177d1cfbe3eac20400ccee8ceb5f678230f2db8 100644
--- a/net/quic/test_tools/crypto_test_utils_test.cc
+++ b/net/quic/test_tools/crypto_test_utils_test.cc
@@ -32,14 +32,14 @@ class ShloVerifier : public ValidateClientHelloResultCallback {
compressed_certs_cache_(compressed_certs_cache) {}
// Verify that the output message is a SHLO.
- void Run(std::unique_ptr<ValidateClientHelloResultCallback::Result> result,
+ void Run(scoped_refptr<ValidateClientHelloResultCallback::Result> result,
std::unique_ptr<ProofSource::Details> /* details */) override {
QuicCryptoNegotiatedParameters params;
string error_details;
DiversificationNonce diversification_nonce;
CryptoHandshakeMessage out;
crypto_config_->ProcessClientHello(
- *result, /*reject_only=*/false, /*connection_id=*/1, server_ip_,
+ result, /*reject_only=*/false, /*connection_id=*/1, server_ip_,
client_addr_, AllSupportedVersions().front(), AllSupportedVersions(),
/*use_stateless_rejects=*/true, /*server_designated_connection_id=*/0,
clock_, QuicRandom::GetInstance(), compressed_certs_cache_, &params,

Powered by Google App Engine
This is Rietveld 408576698