Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2069)

Unified Diff: net/quic/core/quic_crypto_server_stream.h

Issue 2353763002: Use refcounted ownership for ValidateClientHelloResultCallback::Result (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/core/quic_crypto_server_stream.h
diff --git a/net/quic/core/quic_crypto_server_stream.h b/net/quic/core/quic_crypto_server_stream.h
index 6b9da72772e090e396e45fbc9ec30bb6e4867a3d..1a1b44c751281d1a0c3a03fcb7ad9b6ff80c4b28 100644
--- a/net/quic/core/quic_crypto_server_stream.h
+++ b/net/quic/core/quic_crypto_server_stream.h
@@ -125,7 +125,7 @@ class NET_EXPORT_PRIVATE QuicCryptoServerStream
protected:
virtual QuicErrorCode ProcessClientHello(
- const ValidateClientHelloResultCallback::Result& result,
+ scoped_refptr<ValidateClientHelloResultCallback::Result> result,
std::unique_ptr<ProofSource::Details> proof_source_details,
CryptoHandshakeMessage* reply,
DiversificationNonce* out_diversification_nonce,
@@ -146,7 +146,7 @@ class NET_EXPORT_PRIVATE QuicCryptoServerStream
void Cancel();
// From ValidateClientHelloResultCallback
- void Run(std::unique_ptr<Result> result,
+ void Run(scoped_refptr<Result> result,
std::unique_ptr<ProofSource::Details> details) override;
private:
@@ -177,7 +177,7 @@ class NET_EXPORT_PRIVATE QuicCryptoServerStream
// the client hello is complete. Finishes processing of the client
// hello message and handles handshake success/failure.
void FinishProcessingHandshakeMessage(
- const ValidateClientHelloResultCallback::Result& result,
+ scoped_refptr<ValidateClientHelloResultCallback::Result> result,
std::unique_ptr<ProofSource::Details> details);
// Invoked by SendServerConfigUpdateCallback::RunImpl once the proof has been

Powered by Google App Engine
This is Rietveld 408576698