Add design for sql storage, implementation of db that stores the data, not retrieving yet.

experimental/webtry/webtry.go

 package main
 
 import (
         "bytes"
         "crypto/md5"
+        "database/sql"
         "encoding/base64"
         "encoding/json"
         "flag"
         "fmt"
+        _ "github.com/go-sql-driver/mysql"
         "io/ioutil"
         "log"
         "net/http"
         "os"
         "os/exec"
         "path/filepath"
         "strings"
         "text/template"
 )
 
 const (
         RESULT_COMPILE = `c++ -DSK_GAMMA_SRGB -DSK_GAMMA_APPLY_TO_A8 -DSK_SCALAR_TO_FLOAT_EXCLUDED -DSK_ALLOW_STATIC_GLOBAL_INITIALIZERS=1 -DSK_SUPPORT_GPU=0 -DSK_SUPPORT_OPENCL=0 -DSK_FORCE_DISTANCEFIELD_FONTS=0 -DSK_SCALAR_IS_FLOAT -DSK_CAN_USE_FLOAT -DSK_SAMPLES_FOR_X -DSK_BUILD_FOR_UNIX -DSK_USE_POSIX_THREADS -DSK_SYSTEM_ZLIB=1 -DSK_DEBUG -DSK_DEVELOPER=1 -I../../src/core -I../../src/images -I../../tools/flags -I../../include/config -I../../include/core -I../../include/pathops -I../../include/pipe -I../../include/effects -I../../include/ports -I../../src/sfnt -I../../include/utils -I../../src/utils -I../../include/images -g -fno-exceptions -fstrict-aliasing -Wall -Wextra -Winit-self -Wpointer-arith -Wno-unused-parameter -Wno-c++11-extensions -Werror -m64 -fno-rtti -Wnon-virtual-dtor -c ../../../cache/%s.cpp -o ../../../cache/%s.o`
         LINK           = `c++ -m64 -lstdc++ -lm -o ../../../inout/%s -Wl,--start-group ../../../cache/%s.o obj/experimental/webtry/webtry.main.o obj/gyp/libflags.a libskia_images.a libskia_core.a libskia_effects.a obj/gyp/libjpeg.a obj/gyp/libwebp_dec.a obj/gyp/libwebp_demux.a obj/gyp/libwebp_dsp.a obj/gyp/libwebp_enc.a obj/gyp/libwebp_utils.a libskia_utils.a libskia_opts.a libskia_opts_ssse3.a libskia_ports.a libskia_sfnt.a -Wl,--end-group -lpng -lz -lgif -lpthread -lfontconfig -ldl -lfreetype`
 )
 
 var (
         // codeTemplate is the cpp code template the user's code is copied into.
         codeTemplate *template.Template = nil
 
         // index is the main index.html page we serve.
         index []byte
+
+        // db is the database, nil if we don't have an SQL database to store data into.
+        db *sql.DB = nil
 )
 
 // flags
 var (
         useChroot = flag.Bool("use_chroot", false, "Run the compiled code in the schroot jail.")

[mtklein, 2014/04/11 18:12:40]

Think we should change this to something like runLocally to control whether or
not we useChroot and whether or not failing to connect to the DB is fatal?

[jcgregorio, 2014/04/11 20:24:01]

I actually prefer finer grained control. For example, to debug a problem I might
need to run a second instance on the server on port 8001, but not run in the
schroot so that I can debug the code.

+        port      = flag.Int("port", 8000, "Port to run the server on.")
 )
 
 // lineNumbers adds #line numbering to the user's code.
 func LineNumbers(c string) string {
         lines := strings.Split(c, "\n")
         ret := []string{}
         for i, line := range lines {
                 ret = append(ret, fmt.Sprintf("#line %d", i+1))
                 ret = append(ret, line)
         }
@@ skipping 10 matching lines @@
         os.Chdir(cwd)
 
         codeTemplate, err = template.ParseFiles(filepath.Join(cwd, "templates/template.cpp"))
         if err != nil {
                 panic(err)
         }
         index, err = ioutil.ReadFile(filepath.Join(cwd, "templates/index.html"))
         if err != nil {
                 panic(err)
         }
+
+        // Connect to MySQL server. First, get the password from the metadata server.
+        // See https://developers.google.com/compute/docs/metadata#custom.
+        req, err := http.NewRequest("GET", "http://metadata/computeMetadata/v1/instance/attributes/password", nil)

[mtklein, 2014/04/11 18:12:40]

https?

[jcgregorio, 2014/04/11 20:24:01]

The metadata server is http only.

On 2014/04/11 18:12:40, mtklein wrote:

[mtklein, 2014/04/11 21:35:45]

Doesn't that expose the DB password then?

On 2014/04/11 20:24:01, jcgregorio wrote:

+        if err != nil {
+                panic(err)
+        }
+        client := http.Client{}
+        req.Header.Add("X-Google-Metadata-Request", "True")
+        if resp, err := client.Do(req); err == nil {
+                password, err := ioutil.ReadAll(resp.Body)
+                if err != nil {
+                        log.Printf("ERROR: Failed to read password from metadata server: %q\n", err)
+                        panic(err)
+                }
+                // The IP address of the database is found here:
+                //    https://console.developers.google.com/project/31977622648/sql/instances/webtry/overview
+                // And 3306 is the default port for MySQL.
+                db, err = sql.Open("mysql", fmt.Sprintf("webtry:%s@tcp(173.194.83.52:3306)/webtry", password))
+                if err != nil {
+                        log.Printf("ERROR: Failed to open connection to SQL server: %q\n", err)
+                        panic(err)
+                }
+        } else {
+                log.Printf("INFO: Failed to find metadata, unable to connect to MySQL server (Expected when running locally): %q\n", err)
+        }
 }
 
 // userCode is used in template expansion.
 type userCode struct {
         UserCode string
 }
 
 // expandToFile expands the template and writes the result to the file.
 func expandToFile(filename string, code string, t *template.Template) error {
         f, err := os.Create(filename)
@@ skipping 72 matching lines @@
         }
         log.Printf("Error: %s\n%s", message, err.Error())
         resp, err := json.Marshal(m)
         if err != nil {
                 http.Error(w, "Failed to serialize a response", 500)
                 return
         }
         w.Write(resp)
 }
 
+func writeToDatabase(hash string, code string) {
+        if db == nil {
+                return
+        }
+        if _, err := db.Exec("INSERT INTO webtry (code, hash) VALUES(?, ?)", code, hash); err != nil {
+                log.Printf("ERROR: Failed to insert code into database: %q\n", err)
+        }
+}
+
 // mainHandler handles the GET and POST of the main page.
 func mainHandler(w http.ResponseWriter, r *http.Request) {
         if r.Method == "GET" {
                 w.Write(index)
         } else if r.Method == "POST" {
                 w.Header().Set("Content-Type", "application/json")
                 b, err := ioutil.ReadAll(r.Body)
                 if err != nil {
                         reportError(w, r, err, "Failed to read a request body.")
                         return
                 }
-                hash, err := expandCode(LineNumbers(string(b)))
+                code := string(b)

[mtklein, 2014/04/11 18:12:40]

gofmt?  Seems some of this is tabs and some is spaces.  Either's good by me.

[jcgregorio, 2014/04/11 20:24:01]

I've got my editor to run go fmt on Go files every time I save. This seems like
a weirdism in Rietveld, as the entire file is tabs.

On 2014/04/11 18:12:40, mtklein wrote:

[mtklein, 2014/04/11 21:35:45]

Ah.  Good.  I must have just been confused.

+                hash, err := expandCode(LineNumbers(code))
                 if err != nil {
                         reportError(w, r, err, "Failed to write the code to compile.")
                         return
                 }
+                writeToDatabase(hash, code)

[mtklein, 2014/04/11 18:12:40]

This has got me thinking about what should be going into that hash.  Just code,
code and resulting image?

[jcgregorio, 2014/04/11 20:24:01]

See previous comments on saving the image in the database.

On 2014/04/11 18:12:40, mtklein wrote:

                 message, err := doCmd(fmt.Sprintf(RESULT_COMPILE, hash, hash), true)
                 if err != nil {
                         reportError(w, r, err, "Failed to compile the code:\n"+message)
                         return
                 }
                 linkMessage, err := doCmd(fmt.Sprintf(LINK, hash, hash), true)
                 if err != nil {
                         reportError(w, r, err, "Failed to link the code:\n"+linkMessage)
                         return
                 }
@@ skipping 31 matching lines @@
                         return
                 }
                 w.Write(resp)
         }
 }
 
 func main() {
         flag.Parse()
 
         http.HandleFunc("/", mainHandler)
-        log.Fatal(http.ListenAndServe(":8000", nil))
+        log.Fatal(http.ListenAndServe(fmt.Sprintf(":%d", *port), nil))

[mtklein, 2014/04/11 18:12:40]

An alternative I see a lot in Go code is to make port a string flag, defaulting
to ":8000".  This lets you also serve off a particular IP only if you want.

[jcgregorio, 2014/04/11 20:24:01]

Done.

 }