Add support for keyed-call on arrays of fast elements

src/hydrogen-instructions.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 2170 matching lines @@
 
   DECLARE_CONCRETE_INSTRUCTION(CallNamed)
 
  private:
   Handle<String> name_;
 };
 
 
 class HCallFunction V8_FINAL : public HBinaryCall {
  public:
-  HCallFunction(HValue* context, HValue* function, int argument_count)
-      : HBinaryCall(context, function, argument_count) {
+  HCallFunction(HValue* context,
+                HValue* function,
+                int argument_count,
+                bool tailcall)

[danno, 2013/10/02 08:49:11]

Can you please turn this boolean into an enum so that it's clear at the call
site what the meaning of the parameter is, e.g.

enum CallFunctionMode {
  NORMAL_FUNCTION_CALL,
  TAIL_FUNCTION_CALL
}

This would need to get propagated through the various signatures and storage
sites, too.

[Toon Verwaest, 2013/10/02 16:28:16]

Done.

+      : HBinaryCall(context, function, argument_count), tailcall_(tailcall) {
   }
 
   static HCallFunction* New(Zone* zone,
                             HValue* context,
                             HValue* function,
-                            int argument_count) {
-    return new(zone) HCallFunction(context, function, argument_count);
+                            int argument_count,
+                            bool tailcall = false) {
+    return new(zone) HCallFunction(context, function, argument_count, tailcall);
   }
 
+  bool tailcall() { return tailcall_; }
+
   HValue* context() { return first(); }
   HValue* function() { return second(); }
 
   DECLARE_CONCRETE_INSTRUCTION(CallFunction)
+
+ private:
+  bool tailcall_;
 };
 
 
 class HCallGlobal V8_FINAL : public HUnaryCall {
  public:
   HCallGlobal(HValue* context, Handle<String> name, int argument_count)
       : HUnaryCall(context, argument_count), name_(name) {
   }
 
   static HCallGlobal* New(Zone* zone,
@@ skipping 4662 matching lines @@
   virtual HType CalculateInferredType() V8_OVERRIDE {
     return HType::Tagged();
   }
 
   HValue* value() { return OperandAt(0); }
   HValue* map() { return OperandAt(1); }
 
   DECLARE_CONCRETE_INSTRUCTION(CheckMapValue)
 
  protected:
+  virtual int RedefinedOperandIndex() { return 0; }
+
   virtual bool DataEquals(HValue* other) V8_OVERRIDE {
     return true;
   }
 
  private:
   HCheckMapValue(HValue* value,
                  HValue* map) {
     SetOperandAt(0, value);
     SetOperandAt(1, map);
     set_representation(Representation::Tagged());
@@ skipping 108 matching lines @@
   virtual bool IsDeletable() const V8_OVERRIDE { return true; }
 };
 
 
 #undef DECLARE_INSTRUCTION
 #undef DECLARE_CONCRETE_INSTRUCTION
 
 } }  // namespace v8::internal
 
 #endif  // V8_HYDROGEN_INSTRUCTIONS_H_