Fix d8-readline to use modern Persistent API

Fix d8-readline to use modern Persistent API

R=dcarney@chromium.org, svenpanne@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=16870

[adamk, 2013-09-18 00:22:42]

https://codereview.chromium.org/23537060/diff/1/src/d8-readline.cc
File src/d8-readline.cc (right):

https://codereview.chromium.org/23537060/diff/1/src/d8-readline.cc#newcode170
src/d8-readline.cc:170: current_completions.Reset(isolate, Handle<Array>());
This one I'm not so sure about...

[dcarney, 2013-09-18 07:17:02]

https://codereview.chromium.org/23537060/diff/1/src/d8-readline.cc
File src/d8-readline.cc (right):

https://codereview.chromium.org/23537060/diff/1/src/d8-readline.cc#newcode170
src/d8-readline.cc:170: current_completions.Reset(isolate, Handle<Array>());
On 2013/09/18 00:22:42, adamk wrote:
> This one I'm not so sure about...

should just be Reset()

[Sven Panne, 2013-09-18 07:26:45]

FYI: I've just talked to machenbach@, we will have a builder with readline
enabled soon. This has been broken quite regularly in the past, so we should
better catch it on our waterfall...

[adamk, 2013-09-18 16:09:45]

https://codereview.chromium.org/23537060/diff/1/src/d8-readline.cc
File src/d8-readline.cc (right):

https://codereview.chromium.org/23537060/diff/1/src/d8-readline.cc#newcode170
src/d8-readline.cc:170: current_completions.Reset(isolate, Handle<Array>());
On 2013/09/18 07:17:02, dcarney wrote:
> On 2013/09/18 00:22:42, adamk wrote:
> > This one I'm not so sure about...
> 
> should just be Reset()

Hmm, I tried that before and got a crash...will try again when I get in.

[dcarney, 2013-09-18 19:13:39]

On 2013/09/18 16:09:45, adamk wrote:
> https://codereview.chromium.org/23537060/diff/1/src/d8-readline.cc
> File src/d8-readline.cc (right):
> 
> https://codereview.chromium.org/23537060/diff/1/src/d8-readline.cc#newcode170
> src/d8-readline.cc:170: current_completions.Reset(isolate, Handle<Array>());
> On 2013/09/18 07:17:02, dcarney wrote:
> > On 2013/09/18 00:22:42, adamk wrote:
> > > This one I'm not so sure about...
> > 
> > should just be Reset()
> 
> Hmm, I tried that before and got a crash...will try again when I get in.

Ok, well I don't really understand that, but it can't matter too much.  Just
keep what you've got then.

lgtm

[adamk, 2013-09-18 22:10:54]

On 2013/09/18 19:13:39, dcarney wrote:
> On 2013/09/18 16:09:45, adamk wrote:
> > https://codereview.chromium.org/23537060/diff/1/src/d8-readline.cc
> > File src/d8-readline.cc (right):
> > 
> >
https://codereview.chromium.org/23537060/diff/1/src/d8-readline.cc#newcode170
> > src/d8-readline.cc:170: current_completions.Reset(isolate, Handle<Array>());
> > On 2013/09/18 07:17:02, dcarney wrote:
> > > On 2013/09/18 00:22:42, adamk wrote:
> > > > This one I'm not so sure about...
> > > 
> > > should just be Reset()
> > 
> > Hmm, I tried that before and got a crash...will try again when I get in.
> 
> Ok, well I don't really understand that, but it can't matter too much.  Just
> keep what you've got then.
> 
> lgtm

Got it working with the proper version of Reset(), dunno what was up before.

[adamk, 2013-09-18 22:11:12]

Oh, and I'll need an OWNERS lgtm from Sven. Thanks!

[Sven Panne, 2013-09-19 06:01:26]

lgtm

[adamk, 2013-09-20 18:17:27]

Committed patchset #2 manually as r16870 (presubmit successful).