Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 23537056: Fix typo leading to the use of the wrong font in location bar bubbles. (Closed)

Created:
7 years, 3 months ago by Peter Kasting
Modified:
7 years, 3 months ago
Reviewers:
Yuki
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Fix typo leading to the use of the wrong font in location bar bubbles. Along the way, simplify things by passing around FontLists directly more often instead of converting between FontLists and Fonts. BUG=273383 TEST=Type "google.com", hit tab, verify the font isn't shifted down to the bottom of the bubble R=yukishiino@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223919

Patch Set 1 #

Messages

Total messages: 3 (0 generated)
Peter Kasting
In this patch I eliminated the "IME autocompletion" baseline offset adjustment because Label now allows ...
7 years, 3 months ago (2013-09-17 22:49:18 UTC) #1
Yuki
I've tested and confirmed that this CL fixes the issue without a hack on a ...
7 years, 3 months ago (2013-09-18 03:06:48 UTC) #2
Peter Kasting
7 years, 3 months ago (2013-09-18 19:44:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r223919 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698