Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: Source/web/WebBindings.cpp

Issue 23537048: Reduce usage of v8::Isolate::GetCurrent() in NPV8Object (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/V8NPUtils.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebBindings.cpp
diff --git a/Source/web/WebBindings.cpp b/Source/web/WebBindings.cpp
index 9de70dc317500b4ea6812905d87e4a8600996af4..3301ab39f519d543f312183db6c273591f5b972e 100644
--- a/Source/web/WebBindings.cpp
+++ b/Source/web/WebBindings.cpp
@@ -319,7 +319,7 @@ static NPObject* makeIntArrayImpl(const WebVector<int>& data, v8::Isolate* isola
result->Set(i, v8::Number::New(isolate, data[i]));
DOMWindow* window = toDOMWindow(isolate->GetCurrentContext());
- return npCreateV8ScriptObject(0, result, window);
+ return npCreateV8ScriptObject(0, result, window, isolate);
}
static NPObject* makeStringArrayImpl(const WebVector<WebString>& data, v8::Isolate* isolate)
@@ -330,7 +330,7 @@ static NPObject* makeStringArrayImpl(const WebVector<WebString>& data, v8::Isola
result->Set(i, v8String(data[i], isolate));
DOMWindow* window = toDOMWindow(isolate->GetCurrentContext());
- return npCreateV8ScriptObject(0, result, window);
+ return npCreateV8ScriptObject(0, result, window, isolate);
}
bool WebBindings::getRange(NPObject* range, WebRange* webRange)
@@ -380,7 +380,7 @@ void WebBindings::popExceptionHandler()
void WebBindings::toNPVariant(v8::Local<v8::Value> object, NPObject* root, NPVariant* result)
{
- WebCore::convertV8ObjectToNPVariant(object, root, result);
+ WebCore::convertV8ObjectToNPVariant(object, root, result, v8::Isolate::GetCurrent());
}
v8::Handle<v8::Value> WebBindings::toV8Value(const NPVariant* variant)
« no previous file with comments | « Source/bindings/v8/V8NPUtils.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698