Source/bindings/v8/V8NPUtils.h - Issue 23537048: Reduce usage of v8::Isolate::GetCurrent() in NPV8Object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8NPUtils.h

Issue 23537048: Reduce usage of v8::Isolate::GetCurrent() in NPV8Object (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8NPUtils.h

diff --git a/Source/bindings/v8/V8NPUtils.h b/Source/bindings/v8/V8NPUtils.h

index 5ed251f0c8ce10a9e3856f76d1b5301b9edabc17..7c5c53f000ec5243f63d5487cb02e08c1815f369 100644

--- a/Source/bindings/v8/V8NPUtils.h

+++ b/Source/bindings/v8/V8NPUtils.h

@@ -36,7 +36,7 @@

namespace WebCore {

// Convert a V8 Value of any type (string, bool, object, etc) to a NPVariant.

-void convertV8ObjectToNPVariant(v8::Local<v8::Value>, NPObject*, NPVariant*);

+void convertV8ObjectToNPVariant(v8::Local<v8::Value>, NPObject*, NPVariant*, v8::Isolate*);

// Convert a NPVariant (string, bool, object, etc) back to a V8 Value. The owner object is the NPObject which relates to the

// object, if the object is an Object. The created NPObject will be tied to the lifetime of the owner.

« no previous file with comments | « Source/bindings/v8/V8NPObject.cpp ('k') | Source/bindings/v8/V8NPUtils.cpp » ('j') | no next file with comments »